Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kernel specific API calls from ebpf-for-windows #4005

Open
Alan-Jowett opened this issue Nov 12, 2024 · 1 comment
Open

Remove kernel specific API calls from ebpf-for-windows #4005

Alan-Jowett opened this issue Nov 12, 2024 · 1 comment
Assignees
@LakshK98 @vpidatala94
Labels
cleanup Affects API usability or code maintainability but not correctness or applicability P2 triaged Discussed in a triage meeting
Milestone
2501

Comments

@Alan-Jowett
Copy link
Member

All platform specific API calls should be via the cxplat library rather than as usersim thunks.

For example:
https://github.com/microsoft/ebpf-for-windows/blob/e7cae1d72ba57370c8e5cbc13940dd7c7e563eb5/libs/runtime/ebpf_platform.c#L55C1-L61C1
https://github.com/microsoft/ebpf-for-windows/blob/e7cae1d72ba57370c8e5cbc13940dd7c7e563eb5/libs/runtime/ebpf_platform.c#L84C1-L95C1
https://github.com/microsoft/ebpf-for-windows/blob/e7cae1d72ba57370c8e5cbc13940dd7c7e563eb5/libs/runtime/ebpf_platform.c#L145C1-L149C2
@Alan-Jowett Alan-Jowett mentioned this issue Nov 12, 2024
Merged
@dthaler dthaler added the cleanup Affects API usability or code maintainability but not correctness or applicability label Nov 18, 2024
@shankarseal shankarseal added this to the 2501 milestone Nov 18, 2024
@shankarseal shankarseal added the P2 label Nov 18, 2024
@shankarseal
Copy link
Collaborator

Deprecate the ebpf_platform_kernel directory in favor of cxplat.

@shankarseal shankarseal added the triaged Discussed in a triage meeting label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LakshK98 LakshK98

@vpidatala94 vpidatala94

Labels
cleanup Affects API usability or code maintainability but not correctness or applicability P2 triaged Discussed in a triage meeting
Projects
None yet
Milestone
2501
Development

No branches or pull requests
5 participants
@dthaler @Alan-Jowett @LakshK98 @shankarseal @vpidatala94