Skip to content

Commit

Permalink
Removed unnecessary use of node to run a bash script (#703)
Browse files Browse the repository at this point in the history
  • Loading branch information
fpronto authored Sep 19, 2024
1 parent 1f634de commit 79ac1a5
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions vscode/src/devtoolsserver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,7 @@ export class DeveloperToolsManager extends JDEventSource {
"devicescript.jacdac"
)
const isWindows = globalThis.process?.platform === "win32"
const isLinux = globalThis.process?.platform === "linux"
const useShell =
this.lastCreateCliFailed ||
(options.useShell ?? !!devToolsConfig.get("shell"))
Expand All @@ -939,6 +940,9 @@ export class DeveloperToolsManager extends JDEventSource {
const internet =
options.internet || !!devToolsConfig.get("internet")
let cli = nodePath || "node"
if(isLinux) {
cli = "";
}
if (isWindows) {
cli = "node_modules\\.bin\\devicescript.cmd"
} else args.unshift("./node_modules/.bin/devicescript")
Expand Down

0 comments on commit 79ac1a5

Please sign in to comment.