Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blob storage handler #32

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

Ben-Carpenter
Copy link
Contributor

Why

  • Update BlobStorageHandler to match Create and submit a product for signing official documentation from Hardware Dashboard API.

  • Add and update packages

  • General code cleanup and formatting

  • Update AuthorizationHandlerCredentials and AuthorizationHandler

  • Add check for token to prevent call from being made if no token exists.

What Changed

BlobStorageHandler

  • Use of File.OpenRead(filePath)
  • Update UploadAsync()

AuthorizationHandler

  • Add option for x509Certificate2
  • Add CredentialUnavailableException if an AccessToken is not available.

@Ben-Carpenter Ben-Carpenter self-assigned this Aug 2, 2024
@Ben-Carpenter Ben-Carpenter requested a review from a team August 2, 2024 19:20
@Ben-Carpenter Ben-Carpenter added bug Something isn't working enhancement New feature or request labels Aug 2, 2024
@Ben-Carpenter Ben-Carpenter merged commit a16f24b into main Aug 2, 2024
2 checks passed
@Ben-Carpenter Ben-Carpenter deleted the hotfix/bc-update-blob-storage-handler branch August 2, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants