-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Docs: Using an inclusive linter #726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the addition of this into the playbook, thanks for writing this up. I appreciate that you list the benefits and point the developers to the source to learn more.
@@ -0,0 +1,37 @@ | |||
# Inclusive Linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see this guidance for CI. Thanks to propose and create the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jeremydelacruz! I would also look for somewhere we can link to this document from within the main CI guidance page.
… CI guidance page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for adding CI section. Suggested an additional link - action for woke w/ review dog
@fnocera @madossan01 thanks for the reviews! The They're referenced in docs unrelated to my changes, but I wanted to flag it. Do we think I should hold off on merging? |
Pull Request Template
What are you trying to address
inclusive-dev-tools
issue Make contribution to playbook around woke and using an inclusive linter inclusive-dev-tools/woke#35Description of new changes
docs/continuous-integration/inclusive-linting.md
For all pull requests