Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linkcheck #1011

Merged
merged 48 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
54b51dd
remove unneeded file
shiranr Oct 31, 2023
a96e52e
revert changes
shiranr Oct 31, 2023
435c9b0
test linkcheck
shiranr Oct 31, 2023
ccd8583
remove disable errors for link check
shiranr Oct 31, 2023
2638788
temp disable all linters
shiranr Oct 31, 2023
2f50a7f
update version
shiranr Oct 31, 2023
dc666b4
update
shiranr Oct 31, 2023
bc6e79b
fix path
shiranr Oct 31, 2023
ce6781f
fix path
shiranr Oct 31, 2023
4551210
udate plugin
shiranr Oct 31, 2023
fd10717
update plugin
shiranr Oct 31, 2023
1fb6ba0
update plugin
shiranr Oct 31, 2023
82d5a4e
Merge branch 'main' into test_new_linkcheck
shiranr Oct 31, 2023
33eb914
fix path
shiranr Nov 1, 2023
2bedad0
Merge remote-tracking branch 'origin/test_new_linkcheck' into test_ne…
shiranr Nov 1, 2023
fc4886c
update
shiranr Nov 1, 2023
92100b3
fix path
shiranr Nov 1, 2023
fb76d19
fix path
shiranr Nov 1, 2023
53136fd
fix path
shiranr Nov 1, 2023
147e7cf
upgrade
shiranr Nov 1, 2023
16d795b
update
shiranr Nov 1, 2023
a8ba889
update
shiranr Nov 1, 2023
65a67be
update
shiranr Nov 1, 2023
61f4a15
fix path
shiranr Nov 1, 2023
665031c
upgrade
shiranr Nov 1, 2023
28cb52c
change path
shiranr Nov 1, 2023
6f008ca
only errors
shiranr Nov 1, 2023
2615ccc
fix path
shiranr Nov 1, 2023
87e7550
fix path
shiranr Nov 1, 2023
c8ba3ca
update
shiranr Nov 2, 2023
362c7c2
update
shiranr Nov 2, 2023
5ccccd9
readd errors
shiranr Nov 2, 2023
11428f4
revert version
shiranr Nov 2, 2023
83e830c
upgrade version
shiranr Nov 2, 2023
25769d5
clean cache
shiranr Nov 2, 2023
961e81b
remove uneeded steps
shiranr Nov 2, 2023
7ff8a0b
revert change
shiranr Nov 2, 2023
48e2ab5
revert changes
shiranr Nov 2, 2023
3d95852
change time
shiranr Nov 21, 2023
8121c90
ignore link
shiranr Nov 21, 2023
b024468
check linter is running
shiranr Nov 21, 2023
1f85485
see which links are still alive
shiranr Nov 21, 2023
ecfd6cc
see which links are still alive
shiranr Nov 21, 2023
0a76de1
Merge remote-tracking branch 'origin/test_new_linkcheck' into test_ne…
shiranr Nov 21, 2023
9798249
update cache time to 24h
shiranr Nov 21, 2023
e6e85f3
revert
shiranr Nov 21, 2023
6273873
Merge remote-tracking branch 'origin/main' into test_new_linkcheck
shiranr Nov 21, 2023
0f0db1f
revert change
shiranr Nov 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .github/workflows/mega-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,6 @@ jobs:
token: ${{ secrets.PAT || secrets.GITHUB_TOKEN }}
fetch-depth: 0

# - name: List Files
# run: ls -R

# - name: Download linkcheck artifact
# uses: actions/download-artifact@v3
# with:
# name: linkcheck_cache

# MegaLinter
- name: MegaLinter
id: ml
Expand All @@ -63,18 +55,6 @@ jobs:
megalinter-reports
mega-linter.log

- name: List Files
run: ls -R

- name: Save linkcheck cache
uses: actions/upload-artifact@v2
with:
name: linkcheck_cache
path: megalinter-reports/linkcheck/cache

- name: List Files
run: ls -R

# Create pull request if applicable (for now works only on PR from same repository, not from forks)
- name: Create Pull Request with applied fixes
id: cpr
Expand Down
3 changes: 2 additions & 1 deletion .mega-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ ENABLE_LINTERS:
- YAML_YAMLLINT
- MDLINKCHECK_LINKCHECK


SPELL_CSPELL_DISABLE_ERRORS: true
MARKDOWN_MARKDOWN_LINK_CHECK_DISABLE_ERRORS: true
SHOW_ELAPSED_TIME: true
Expand All @@ -25,4 +26,4 @@ LOG_LEVEL: WARNING
MARKDOWN_MARKDOWN_LINK_CHECK_ARGUMENTS: "-q"
# DISABLE_ERRORS: true # Uncomment if you want MegaLinter to detect errors but not block CI to pass
PLUGINS:
- https://raw.githubusercontent.com/shiranr/linkcheck/main/mega-linter-plugin-linkcheck/linkcheck.megalinter-descriptor.yml
- https://raw.githubusercontent.com/shiranr/linkcheck/v2.0.17.beta/mega-linter-plugin-linkcheck/linkcheck.megalinter-descriptor.yml
1 change: 1 addition & 0 deletions docs/accessibility/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,4 @@ Before you get to testing, you can make some small changes in how you write code
* [Web Content Accessibility Guidelines (WCAG)](https://www.w3.org/TR/WCAG20/#intro)
* [Accessibility Guidelines and Requirements | Microsoft Style Guide](https://learn.microsoft.com/en-us/style-guide/accessibility/accessibility-guidelines-requirements)
* [Google Developer Style Guide: Write Accessible Documentation](https://developers.google.com/style/accessibility)

1 change: 0 additions & 1 deletion docs/code-reviews/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,5 @@ See also [Pull Request Template](pull-request-template/pull-request-template.md)
* [Google approach to PR size](https://google.github.io/eng-practices/review/developer/small-cls.html)
* [Feature Flags](https://www.martinfowler.com/articles/feature-toggles.html)
* [Facebook approach to hidden features](https://launchdarkly.com/blog/secret-to-facebooks-hacker-engineering-culture/)
* [Azure approach to canary releases](https://learn.microsoft.com/azure/architecture/framework/devops/release-engineering-cd#stage-your-workloads)
* [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0-beta.2/)
* [Angular Commit types](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type)
7 changes: 4 additions & 3 deletions linkcheck.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@
"https://eclipse.dev/mat/",
"https://cloud.google.com/blog/products/gcp/cre-life-lessons-what-is-a-dark-launch-and-what-does-it-do-for-me",
"https://miro.com/guides/retrospectives/ideas-games",
"https://interpret.ml/"
"https://interpret.ml/",
"https://dash.harvard.edu/bitstream/handle/1/38323292/4_Wood_Final.pdf?sequence=1&isAllowed=y"
],
"only_errors": false,
"only_errors": true,
"cache_duration": "24h",
"cache_output_path": "megalinter-reports/linkcheck/cache"
"cache_output_path": "/github/workspace/megalinter-reports/linchcheck-cache"
}
Loading