Enhancement: Add Unused Dependency Detector #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipati
reviewed
Jan 5, 2021
| new Failure( | ||
| ruleName, | ||
| asBollFile("package.json"), | ||
| asBollLineNumber(0), |
There was a problem hiding this comment.
Shouldn't we be showing the exact line number for missing dependency instead of 0?
vipati
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried implementing the feature mentioned in #52.
Bumping major version because this could not be implemented using the existing
PackageRuletype. I created a new rule type and as a result had to changechecksin the configuration to be able to specify two different types of rules:Because I had to change the config object, this will break existing configurations when updating the package. As such, I've considered this a major version bump.