Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fluent-bit issues #8198 and #8025 #9121

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

sindhu-karri
Copy link
Contributor

@sindhu-karri sindhu-karri commented May 16, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Fixes two of the fluent-bit issues raised at https://microsoft.visualstudio.com/OS/_workitems/edit/50531424

  1. Back porting patch to fix Potential log loss during high load at Multiline & Rewrite Tag Filter (in_emitter) fluent/fluent-bit#8198. Link to fix: in_emitter: Fix single record chunks and respect mem_buf_limit pause fluent/fluent-bit#8473
  2. Back porting patch to fix in_tail: missing log for offset processing due to non-existent old inodes in sqlite. fluent/fluent-bit#8025. Link to fix: in_tail: Preventing incorrect inode usage from db. #8025 fluent/fluent-bit#8062
Change Log
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label May 16, 2024
@sindhu-karri sindhu-karri changed the title Fix Fluent-bit issue Potential log loss during high load at Multiline… Fix Fluent-bit issue fix #8198 May 16, 2024
@sindhu-karri sindhu-karri changed the title Fix Fluent-bit issue fix #8198 Fix Fluent-bit issue #8198 May 16, 2024
@sindhu-karri sindhu-karri marked this pull request as ready for review May 16, 2024 16:28
@sindhu-karri sindhu-karri requested a review from a team as a code owner May 16, 2024 16:28
@sindhu-karri sindhu-karri changed the title Fix Fluent-bit issue #8198 Fix Fluent-bit issue #8198 and #8025 Jun 3, 2024
@sindhu-karri sindhu-karri changed the title Fix Fluent-bit issue #8198 and #8025 Fix Fluent-bit issues #8198 and #8025 Jun 3, 2024
@sindhu-karri sindhu-karri requested a review from a team as a code owner June 5, 2024 17:18
Copy link
Contributor

@eric-desrochers eric-desrochers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customer (Amol) has confirmed that e2e tests are passing. Approving the PR on behalf of Stable Maintainer team.

@sindhu-karri sindhu-karri merged commit 6b57d92 into main Jun 6, 2024
10 checks passed
@sindhu-karri sindhu-karri deleted the sindhu/fix_fluent-bit_regression_bug50531424 branch June 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants