Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcBox 3.0 - enhancing error handling, improving script execution and adding new configuration options #2647

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

janegilring
Copy link
Contributor

This pull request includes several updates to the azure_jumpstart_arcbox project, focusing on enhancing error handling, improving script execution, and adding new configuration options. The most important changes are summarized below:

Error Handling Enhancements:

  • Added $ErrorActionPreference = $env:ErrorActionPreference at the beginning of multiple scripts to ensure consistent error handling behavior. (azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1, azure_jumpstart_arcbox/artifacts/DataOpsLogonScript.ps1, azure_jumpstart_arcbox/artifacts/DevOpsLogonScript.ps1, azure_jumpstart_arcbox/artifacts/WinGet.ps1) [1] [2] [3] [4]

Script Execution Improvements:

  • Combined the Invoke-Command calls for onboarding nested Windows VMs into a single call for efficiency. (azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1)

Configuration Options:

  • Introduced a new debugEnabled parameter to control the ErrorActionPreference setting, allowing easier debugging of automation scripts. (azure_jumpstart_arcbox/artifacts/Bootstrap.ps1, azure_jumpstart_arcbox/bicep/clientVm/clientVm.bicep, azure_jumpstart_arcbox/bicep/main.bicep) [1] [2] [3]
  • Updated the commandToExecute for the Bootstrap.ps1 script to include the new debugEnabled parameter. (azure_jumpstart_arcbox/bicep/clientVm/clientVm.bicep)

Cleanup and Optimization:

  • Removed temporary workaround for the Posh-SSH module installation as the issue has been resolved. (azure_jumpstart_arcbox/artifacts/Bootstrap.ps1)

Additional Software Installations:

  • Added configuration to install the Istio command line utility using winget in the dataops.dsc.yml and devops.dsc.yml files. (azure_jumpstart_arcbox/artifacts/dsc/dataops.dsc.yml, azure_jumpstart_arcbox/artifacts/dsc/devops.dsc.yml) [1] [2]

@janegilring janegilring added the ArcBox Jumpstart ArcBox related label Aug 6, 2024
@janegilring janegilring added this to the August 2024 milestone Aug 6, 2024
@janegilring janegilring self-assigned this Aug 6, 2024

Hi janegilring! Thank you for opening this Pull Request. Someone will review it soon. Thank you for committing to making the Arc Jumpstart better.

@janegilring janegilring merged commit 8308286 into microsoft:arcbox_3.0 Aug 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcBox Jumpstart ArcBox related
Projects
Development

Successfully merging this pull request may close these issues.

1 participant