Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily introduces changes to improve the scripts in the
azure_jumpstart_arcbox/artifacts/
directory. The key changes include modifying the wallpaper change process, restructuring the deployment logs bundle creation process, and correcting a typo in theRunAfterClientVMADJoin.ps1
script.Modifications to the wallpaper change process:
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1
,azure_jumpstart_arcbox/artifacts/DataOpsLogonScript.ps1
,azure_jumpstart_arcbox/artifacts/DevOpsLogonScript.ps1
: The code for changing the wallpaper has been simplified. Instead of using a complex script to change the wallpaper, the code now converts the wallpaper image to a bitmap and then sets the desktop background using theSet-JSDesktopBackground
function. [1] [2] [3]Restructuring the deployment logs bundle creation process:
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1
,azure_jumpstart_arcbox/artifacts/DataOpsLogonScript.ps1
,azure_jumpstart_arcbox/artifacts/DevOpsLogonScript.ps1
: The process for creating the deployment logs bundle has been restructured. Instead of executing the logs bundle creation script in a new window, the logs are now copied to a temporary directory to avoid a "file is being used by another process" error, and then compressed into a zip file. [1] [2]Typo correction:
azure_jumpstart_arcbox/artifacts/RunAfterClientVMADJoin.ps1
: Corrected a typo in a comment from "Activectory" to "Active Directory".