Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcBox 3.0 - optimizations #2606

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

janegilring
Copy link
Contributor

This pull request primarily introduces changes to improve the scripts in the azure_jumpstart_arcbox/artifacts/ directory. The key changes include modifying the wallpaper change process, restructuring the deployment logs bundle creation process, and correcting a typo in the RunAfterClientVMADJoin.ps1 script.

Modifications to the wallpaper change process:

  • azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1, azure_jumpstart_arcbox/artifacts/DataOpsLogonScript.ps1, azure_jumpstart_arcbox/artifacts/DevOpsLogonScript.ps1: The code for changing the wallpaper has been simplified. Instead of using a complex script to change the wallpaper, the code now converts the wallpaper image to a bitmap and then sets the desktop background using the Set-JSDesktopBackground function. [1] [2] [3]

Restructuring the deployment logs bundle creation process:

  • azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1, azure_jumpstart_arcbox/artifacts/DataOpsLogonScript.ps1, azure_jumpstart_arcbox/artifacts/DevOpsLogonScript.ps1: The process for creating the deployment logs bundle has been restructured. Instead of executing the logs bundle creation script in a new window, the logs are now copied to a temporary directory to avoid a "file is being used by another process" error, and then compressed into a zip file. [1] [2]

Typo correction:

Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
@janegilring janegilring added the ArcBox Jumpstart ArcBox related label Jul 9, 2024
@janegilring janegilring added this to the July 2024 milestone Jul 9, 2024
@janegilring janegilring self-assigned this Jul 9, 2024

Hi janegilring! Thank you for opening this Pull Request. Someone will review it soon. Thank you for committing to making the Azure Arc Jumpstart better.

@janegilring janegilring merged commit 7970af1 into microsoft:arcbox_3.0 Jul 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcBox Jumpstart ArcBox related
Projects
Development

Successfully merging this pull request may close these issues.

1 participant