-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ollama to Magentic One #4280
Conversation
@microsoft-github-policy-service agree |
This is great thank you! So it can be used in more places would you mind moving it to |
This is awesome! As Jack mentioned, we'd love for this to be used broadly in autogen beyond magentic-one and in the AgentChat version of magentic-one Quoting @jackgerrits : "Creating a custom model client is a matter of implementing this interface." Happy to help on this |
Possible to set up Ollama on CI action to test this? |
@jackgerrits @husseinmozannar @ekzhu Moved the Ollama Client to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for moving it to ext for broader applicability.
We should add unit tests as Eric mentioned, but I trust that this can be done in a follow up.
python/packages/autogen-ext/src/autogen_ext/models/_ollama/_ollama_client.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-ext/src/autogen_ext/models/_ollama/_ollama_client.py
Outdated
Show resolved
Hide resolved
97fd6cc
I am not sure how this pull request got closed by me merging a different PR. I definitely did not mean to do this. Did you by any chance update your main branch unintentionally @MervinPraison ? @MervinPraison are you able to create a new PR? We definitely still want this change and I would really love for you to get the credit for the commit |
Not sure why it happened like that |
@jackgerrits |
Why are these changes needed?
Related Issue Number
Checks