Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to read the configure #47

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lindexi
Copy link

@lindexi lindexi commented Jan 12, 2017

The dever want to get the configure but the OptionsPageCS not say how to get the configure.

Add the static OptionsPagePackageCS EnsurceOptionsPagePackageCs get the package that can get the configure.

Copy link
Contributor

@AlexEyler AlexEyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty common pattern that we see extension authors use to grab the dialog page for options. I'd just recommend a couple small changes to make it a little clearer for other users.

Options_Page/C#/OptionsPagePackage.cs Outdated Show resolved Hide resolved
Options_Page/C#/OptionsPagePackage.cs Outdated Show resolved Hide resolved
@msftclas
Copy link

msftclas commented Apr 11, 2018

CLA assistant check
All CLA requirements met.

@lindexi
Copy link
Author

lindexi commented Jun 14, 2018

@madskristensen Why close it?

@madskristensen
Copy link
Contributor

Perhaps a mistake. Reopening

@lindexi
Copy link
Author

lindexi commented May 14, 2019

@AlexEyler Can merge?

@lindexi lindexi requested a review from AlexEyler March 15, 2020 11:10
@soroshsabz
Copy link

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants