Skip to content

Commit

Permalink
Changed to version 3.4.2; minor edits to CMake system
Browse files Browse the repository at this point in the history
SEAL CMake config script now disregards patch version number for
compatibility check, so find_package(SEAL 3.4 REQUIRED) works for all
patch versions.
  • Loading branch information
kimlaine committed Oct 18, 2019
1 parent 75ed2fb commit 8460b0a
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 8 deletions.
4 changes: 4 additions & 0 deletions Changes.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# List of Changes

## Version 3.4.2

This patch fixes [Issue 66](https://github.com/microsoft/SEAL/issues/66) reported on GitHub.

## Version 3.4.1

This patch fixes a few issues with ZLIB support on Windows. Specifically,
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ cd ../..
It is very easy to link your own applications and libraries with Microsoft SEAL if
you use CMake. Simply add the following to your `CMakeLists.txt`:
````
find_package(SEAL 3.4.1 EXACT REQUIRED)
find_package(SEAL 3.4 REQUIRED)
target_link_libraries(<your target> SEAL::seal)
````
If Microsoft SEAL was installed globally, the above `find_package` command will likely
Expand Down
4 changes: 2 additions & 2 deletions dotnet/native/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@

cmake_minimum_required(VERSION 3.12)

project(SEALNetNative VERSION 3.4.1 LANGUAGES CXX C)
project(SEALNetNative VERSION 3.4.2 LANGUAGES CXX C)

# Import Microsoft SEAL
find_package(SEAL 3.4.1 EXACT REQUIRED
find_package(SEAL 3.4.2 EXACT REQUIRED
# Providing a path so this can be built without installing Microsoft SEAL
PATHS ${SEALNetNative_SOURCE_DIR}/../../native/src/cmake
)
Expand Down
4 changes: 2 additions & 2 deletions native/examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

cmake_minimum_required(VERSION 3.12)

project(SEALExamples VERSION 3.4.1 LANGUAGES CXX)
project(SEALExamples VERSION 3.4.2 LANGUAGES CXX)

# Executable will be in ../bin
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${SEALExamples_SOURCE_DIR}/../bin)
Expand All @@ -20,7 +20,7 @@ target_sources(sealexamples
)

# Import Microsoft SEAL
find_package(SEAL 3.4.1 EXACT REQUIRED
find_package(SEAL 3.4.2 EXACT REQUIRED
# Providing a path so this can be built without installing Microsoft SEAL
PATHS ${SEALExamples_SOURCE_DIR}/../src/cmake
)
Expand Down
4 changes: 2 additions & 2 deletions native/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

cmake_minimum_required(VERSION 3.12)

project(SEAL VERSION 3.4.1 LANGUAGES CXX C)
project(SEAL VERSION 3.4.2 LANGUAGES CXX C)

if(MSVC)
if(ALLOW_COMMAND_LINE_BUILD)
Expand Down Expand Up @@ -401,7 +401,7 @@ install(
write_basic_package_version_file(
${SEAL_CONFIG_VERSION_FILENAME}
VERSION ${SEAL_VERSION}
COMPATIBILITY ExactVersion)
COMPATIBILITY SameMinorVersion)

# Install config and module files
install(
Expand Down
2 changes: 1 addition & 1 deletion native/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${SEALTest_SOURCE_DIR}/../bin)
add_executable(sealtest seal/testrunner.cpp)

# Import Microsoft SEAL
find_package(SEAL 3.4.1 EXACT REQUIRED
find_package(SEAL 3.4.2 EXACT REQUIRED
# Providing a path so this can be built without installing Microsoft SEAL
PATHS ${SEALTest_SOURCE_DIR}/../src/cmake
)
Expand Down

0 comments on commit 8460b0a

Please sign in to comment.