-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join function #2728
base: main
Are you sure you want to change the base?
Join function #2728
Conversation
✅ No public API change. #Resolved |
✅ No public API change. #Resolved |
✅ No public API change. #Resolved |
src/tests/Microsoft.PowerFx.Core.Tests.Shared/ExpressionTestCases/Join.txt
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Core/Functions/FunctionScopeInfo.cs
Outdated
Show resolved
Hide resolved
src/tests/Microsoft.PowerFx.Core.Tests.Shared/ExpressionTestCases/Join.txt
Outdated
Show resolved
Hide resolved
✅ No public API change. #Resolved |
✅ No public API change. #Resolved |
src/tests/Microsoft.PowerFx.Core.Tests.Shared/ExpressionTestCases/Join.txt
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryTable.cs
Outdated
Show resolved
Hide resolved
src/tests/Microsoft.PowerFx.Core.Tests.Shared/ExpressionTestCases/Join.txt
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryTable.cs
Outdated
Show resolved
Hide resolved
✅ No public API change. #Resolved |
✅ No public API change. #Resolved |
src/libraries/Microsoft.PowerFx.Interpreter/Environment/PowerFxConfigExtensions.cs
Show resolved
Hide resolved
src/tests/Microsoft.PowerFx.Core.Tests.Shared/ExpressionTestCases/Join.txt
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Interpreter/Functions/IAsyncTexlFunctionJoin.cs
Show resolved
Hide resolved
✅ No public API change. #Resolved |
src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryTable.cs
Outdated
Show resolved
Hide resolved
✅ No public API change. #Resolved |
✅ No public API change. |
Suggestion: start from ScopeArgs instead of 1; we don't need to do any of the logic inside this loop for any of the scope arguments, since they have already been visited (we'd need to move line 4655 ( Refers to: src/libraries/Microsoft.PowerFx.Core/Binding/Binder.cs:4623 in a438704. [](commit_id = a438704, deletion_comment = False) |
Table({Fruit:"Grapes",Price:220,Purchase:Date(2015,10,1),RowId:1,SupplierId:"AAA111"},{Fruit:"Lemons",Price:31,Purchase:Date(2015,10,1),RowId:2,SupplierId:"BBB222"},{Fruit:"Lemons",Price:29,Purchase:Date(2015,10,2),RowId:3,SupplierId:"AAA111"},{Fruit:"Grapes",Price:210,Purchase:Date(2015,10,2),RowId:4,SupplierId:"AAA111"},{Fruit:"Lemons",Price:30,Purchase:Date(2015,10,3),RowId:5,SupplierId:"BBB222"},{Fruit:"Bananas",Price:12,Purchase:Date(2015,10,3),RowId:6,SupplierId:"AAA111"},{Fruit:"Apples",Price:15,Purchase:Date(2015,12,3),RowId:7,SupplierId:"CCC333"},{Fruit:"Mangos",Price:30,Purchase:Date(2016,12,3),RowId:8,SupplierId:"DDD444"}) | ||
|
||
// Inner | ||
>> Join(t1, t2, LeftRecord.Id = RightRecord.SupplierId, JoinType.Inner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ No public API change. |
Join(t1, t2, LeftRecord.id = RightRecord.refid) //JoinType.Inner by default
Join(t1, t2, LeftRecord.id = RightRecord.refid, JoinType.Inner) // JoinType.Inner / JoinType.Left / JoinType.Right / JoinType.Full
Join(t1, t2, LeftRecord.id = RightRecord.refid, JoinType.Inner, LeftRecord.id As NewId, ...) // Renaming columns to avoid name collision