Remove function

src/libraries/Microsoft.PowerFx.Core/App/IExternalDocumentProperties.cs

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using System.Collections.Generic;
-
 namespace Microsoft.PowerFx.Core.App
 {
     internal interface IExternalDocumentProperties

src/libraries/Microsoft.PowerFx.Core/Localization/Strings.cs

@@ -523,8 +523,10 @@ internal static class TexlStrings
         public static StringGetter AboutClearCollect = (b) => StringResources.Get("AboutClearCollect", b);
 
         public static StringGetter AboutRemove = (b) => StringResources.Get("AboutRemove", b);
-        public static StringGetter RemoveDataSourceArg = (b) => StringResources.Get("RemoveDataSourceArg", b);
-        public static StringGetter RemoveRecordsArg = (b) => StringResources.Get("RemoveRecordsArg", b);
+        public static StringGetter RemoveArg1 = (b) => StringResources.Get("RemoveArg1", b);
+        public static StringGetter RemoveArg2 = (b) => StringResources.Get("RemoveArg2", b);
+        public static StringGetter RemoveArg3 = (b) => StringResources.Get("RemoveArg3", b);
+        public static StringGetter RemoveAllArg2 = (b) => StringResources.Get("RemoveAllArg2", b);
 
         public static StringGetter AboutDec2Hex = (b) => StringResources.Get("AboutDec2Hex", b);
         public static StringGetter Dec2HexArg1 = (b) => StringResources.Get("Dec2HexArg1", b);
@@ -649,6 +651,7 @@ internal static class TexlStrings
         public static ErrorResourceKey ErrBadSchema_ExpectedType = new ErrorResourceKey("ErrBadSchema_ExpectedType");
         public static ErrorResourceKey ErrInvalidArgs_Func = new ErrorResourceKey("ErrInvalidArgs_Func");
         public static ErrorResourceKey ErrNeedTable_Func = new ErrorResourceKey("ErrNeedTable_Func");
+        public static ErrorResourceKey ErrNeedTable_Arg = new ErrorResourceKey("ErrNeedTable_Arg");
         public static ErrorResourceKey ErrNeedTableCol_Func = new ErrorResourceKey("ErrNeedTableCol_Func");
         public static ErrorResourceKey ErrNotAccessibleInCurrentContext = new ErrorResourceKey("ErrNotAccessibleInCurrentContext");
         public static ErrorResourceKey ErrInternalControlInInputProperty = new ErrorResourceKey("ErrInternalControlInInputProperty");
@@ -843,5 +846,8 @@ internal static class TexlStrings
         public static ErrorResourceKey ErrInvalidDataSourceForFunction = new ErrorResourceKey("ErrInvalidDataSourceForFunction");
         public static ErrorResourceKey ErrInvalidArgumentExpectedType = new ErrorResourceKey("ErrInvalidArgumentExpectedType");
         public static ErrorResourceKey ErrUnsupportedTypeInTypeArgument = new ErrorResourceKey("ErrUnsupportedTypeInTypeArgument");
+        public static ErrorResourceKey ErrCollectionDoesNotAcceptThisType = new ErrorResourceKey("ErrCollectionDoesNotAcceptThisType");
+        public static ErrorResourceKey ErrNeedAll = new ErrorResourceKey("ErrNeedAll");
+        public static ErrorResourceKey ErrNeedCollection_Func = new ErrorResourceKey("ErrNeedCollection_Func");
     }
 }

src/libraries/Microsoft.PowerFx.Core/Public/Config/Features.cs

@@ -91,6 +91,11 @@ public sealed class Features
         /// </summary>
         internal bool IsLookUpReductionDelegationEnabled { get; set; }
 
+        /// <summary>
+        /// Temporary flag.
+        /// </summary>
+        internal bool IsRemoveAllDelegationEnabled { get; set; }
+
         internal static Features None => new Features();
 
         public static Features PowerFxV1 => new Features

src/libraries/Microsoft.PowerFx.Core/Public/Config/SymbolTable.cs

@@ -348,10 +348,15 @@ internal void AddFunction(TexlFunction function)
         {
             using var guard = _guard.Enter(); // Region is single threaded.
             Inc();
-            _functions.Add(function);
+            _functions.Add(function);
+
+            if (EnumStoreBuilder == null)
+            {
+                _enumStoreBuilder = new EnumStoreBuilder();
+            }
 
             // Add any associated enums 
-            EnumStoreBuilder?.WithRequiredEnums(new TexlFunctionSet(function));
+            EnumStoreBuilder.WithRequiredEnums(new TexlFunctionSet(function));
         }
 
         internal EnumStoreBuilder EnumStoreBuilder

src/libraries/Microsoft.PowerFx.Core/Public/Values/CollectionTableValue.cs

@@ -220,7 +220,7 @@ public override async Task<DValue<BooleanValue>> RemoveAsync(IEnumerable<Formula
                 if (!found)
                 {
                     // https://github.com/microsoft/Power-Fx/issues/2618
-                    errors.Add(new ExpressionError() { Message = "The specified record was not found.", Kind = ErrorKind.NotFound });
+                    errors.Add(new ExpressionError() { Kind = ErrorKind.NotFound });
                 }
             }
 

src/libraries/Microsoft.PowerFx.Core/Public/Values/TableValue.cs

@@ -234,7 +234,7 @@ public virtual async Task<DValue<BooleanValue>> ClearAsync(CancellationToken can
         {
             return DValue<BooleanValue>.Of(NotImplementedError(IRContext));
         }
-
+
         /// <summary>
         /// Patch implementation for derived classes.
         /// </summary>