Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Culture support for in operator and Sort function #2539

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into gregli/culture-tr

e44f670
Select commit
Loading
Failed to load commit list.
Open

Culture support for in operator and Sort function #2539

Merge branch 'main' into gregli/culture-tr
e44f670
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Power-Fx PR (PFX) failed Aug 28, 2024 in 23m 8s

Build #20240828.7 had test failures

Details

Tests

  • Failed: 16 (0.01%)
  • Passed: 118,291 (99.47%)
  • Other: 614 (0.52%)
  • Total: 118,921
Code coverage

  • 66739 of 84378 blocks covered (79.10%)
  • 46929 of 60902 lines covered (77.06%)

Annotations

Check failure on line 6826 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Power-Fx PR (PFX)

Build log #L6826

[xUnit.net 00:01:42.44]     Canvas_Float(t: 4 Culture_en-US.txt : 124 - SortByColumns( [ "Z", "İ", "z", "I", "J", "j", "ı", "a", "h", "i", "A", "H"], "Value" ) = Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"}) - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult) [FAIL]

Check failure on line 7458 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Power-Fx PR (PFX)

Build log #L7458

[xUnit.net 00:01:46.52]     Canvas_Float(t: 4 Culture_en-US.txt : 130 - Concat( SortByColumns( Split( "d D e E f F g G h H i I j J k K l L m M n N o O p P r R s S t T u U v V y Y z Z Ç ç Ş ş Ü ü Ö ö İ ı Ğ ğ a A b B c C", " " ), "Value" ), Value, " " ) = "a A b B c C ç Ç d D e E f F g G ğ Ğ h H i I İ ı j J k K l L m M n N o O ö Ö p P r R s S ş Ş t T u U ü Ü v V y Y z Z" - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult) [FAIL]

Check failure on line 24084 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Power-Fx PR (PFX)

Build log #L24084

[xUnit.net 00:03:05.95]     Canvas_Float(t: 4 Culture_en-US.txt : 127 - Concat( Sort( Split( "j J k K l L m M n N o O p P r R s S t T u U v V y Y z Z Ç ç Ş ş Ü ü Ö ö İ ı Ğ ğ a A b B c C d D e E f F g G h H i I", " " ), Value ), Value, " " ) = "a A b B c C ç Ç d D e E f F g G ğ Ğ h H i I İ ı j J k K l L m M n N o O ö Ö p P r R s S ş Ş t T u U ü Ü v V y Y z Z" - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult) [FAIL]

Check failure on line 24936 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Power-Fx PR (PFX)

Build log #L24936

[xUnit.net 00:03:08.83]     Canvas_Float(t: 4 Culture_en-US.txt : 121 - Sort( [ "Z", "İ", "z", "I", "J", "j", "ı", "a", "h", "i", "A", "H"], Value ) = Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"}) - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult) [FAIL]

Check failure on line 1 in Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(t: 4 Culture_en-US.txt : 121 - Sort( [ "Z", "İ", "z", "I", "J", "j", "ı", "a", "h", "i", "A", "H"], Value ) = Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"}) - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Power-Fx PR (PFX)

Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(t: 4 Culture_en-US.txt : 121 - Sort( [ "Z", "İ", "z", "I", "J", "j", "ı", "a", "h", "i", "A", "H"], Value ) = Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"}) - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult)

Test Culture_en-US.txt:121: 
  Expected: Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"})
  Actual  : Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"ı"},{Value:"İ"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"})
Raw output
   at Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.RunExpressionTestCase(ExpressionTestCase testCase, Features features, Boolean numberIsFloat, ITestOutputHelper output) in \src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\FileExpressionEvaluationTests.cs:line 121
   at Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(ExpressionTestCase t) in \src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\FileExpressionEvaluationTests.cs:line 80

Check failure on line 1 in Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(t: 4 Culture_en-US.txt : 127 - Concat( Sort( Split( "j J k K l L m M n N o O p P r R s S t T u U v V y Y z Z Ç ç Ş ş Ü ü Ö ö İ ı Ğ ğ a A b B c C d D e E f F g G h H i I", " " ), Value ), Value, " " ) = "a A b B c C ç Ç d D e E f F g G ğ Ğ h H i I İ ı j J k K l L m M n N o O ö Ö p P r R s S ş Ş t T u U ü Ü v V y Y z Z" - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Power-Fx PR (PFX)

Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(t: 4 Culture_en-US.txt : 127 - Concat( Sort( Split( "j J k K l L m M n N o O p P r R s S t T u U v V y Y z Z Ç ç Ş ş Ü ü Ö ö İ ı Ğ ğ a A b B c C d D e E f F g G h H i I", " " ), Value ), Value, " " ) = "a A b B c C ç Ç d D e E f F g G ğ Ğ h H i I İ ı j J k K l L m M n N o O ö Ö p P r R s S ş Ş t T u U ü Ü v V y Y z Z" - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult)

Test Culture_en-US.txt:127: 
  Expected: "a A b B c C ç Ç d D e E f F g G ğ Ğ h H i I İ ı j J k K l L m M n N o O ö Ö p P r R s S ş Ş t T u U ü Ü v V y Y z Z"
  Actual  : "a A b B c C ç Ç d D e E f F g G ğ Ğ h H i I ı İ j J k K l L m M n N o O ö Ö p P r R s S ş Ş t T u U ü Ü v V y Y z Z"
Raw output
   at Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.RunExpressionTestCase(ExpressionTestCase testCase, Features features, Boolean numberIsFloat, ITestOutputHelper output) in \src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\FileExpressionEvaluationTests.cs:line 121
   at Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(ExpressionTestCase t) in \src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\FileExpressionEvaluationTests.cs:line 80

Check failure on line 1 in Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(t: 4 Culture_en-US.txt : 124 - SortByColumns( [ "Z", "İ", "z", "I", "J", "j", "ı", "a", "h", "i", "A", "H"], "Value" ) = Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"}) - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Power-Fx PR (PFX)

Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(t: 4 Culture_en-US.txt : 124 - SortByColumns( [ "Z", "İ", "z", "I", "J", "j", "ı", "a", "h", "i", "A", "H"], "Value" ) = Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"}) - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult)

Test Culture_en-US.txt:124: 
  Expected: Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"})
  Actual  : Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"ı"},{Value:"İ"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"})
Raw output
   at Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.RunExpressionTestCase(ExpressionTestCase testCase, Features features, Boolean numberIsFloat, ITestOutputHelper output) in \src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\FileExpressionEvaluationTests.cs:line 121
   at Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Float(ExpressionTestCase t) in \src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\FileExpressionEvaluationTests.cs:line 80

Check failure on line 1 in Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Decimal(t: 4 Culture_en-US.txt : 121 - Sort( [ "Z", "İ", "z", "I", "J", "j", "ı", "a", "h", "i", "A", "H"], Value ) = Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"}) - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Power-Fx PR (PFX)

Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Decimal(t: 4 Culture_en-US.txt : 121 - Sort( [ "Z", "İ", "z", "I", "J", "j", "ı", "a", "h", "i", "A", "H"], Value ) = Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"}) - Setup: RegEx,CultureInfo("en-US"),PowerFxV1CompatibilityRules,ConsistentOneColumnTableResult)

Test Culture_en-US.txt:121: 
  Expected: Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"İ"},{Value:"ı"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"})
  Actual  : Table({Value:"a"},{Value:"A"},{Value:"h"},{Value:"H"},{Value:"i"},{Value:"I"},{Value:"ı"},{Value:"İ"},{Value:"j"},{Value:"J"},{Value:"z"},{Value:"Z"})
Raw output
   at Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.RunExpressionTestCase(ExpressionTestCase testCase, Features features, Boolean numberIsFloat, ITestOutputHelper output) in \src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\FileExpressionEvaluationTests.cs:line 121
   at Microsoft.PowerFx.Interpreter.Tests.FileExpressionEvaluationTests.V1_Decimal(ExpressionTestCase t) in \src\tests\Microsoft.PowerFx.Interpreter.Tests.Shared\FileExpressionEvaluationTests.cs:line 72