Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filepaths to use #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update filepaths to use #58

wants to merge 2 commits into from

Conversation

AryaanSheth
Copy link

Update paths to use os.path.join() for better readability

@AryaanSheth
Copy link
Author

@microsoft-github-policy-service agree

@AryaanSheth AryaanSheth mentioned this pull request Oct 29, 2024
Open
@nmstoker
Copy link
Contributor

IMHO this doesn't really help readability and if that's the aim it would be better to use Pathlib

@AryaanSheth
Copy link
Author

I'll take a look at Pathlib and use that rather than os.path.join()

@nmstoker
Copy link
Contributor

Great work! Simplifies things particularly where you reuse a base path as was possible in a few of the later files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AryaanSheth @nmstoker