Release 2303 #13
Release 2303 #13
Conversation
|
@tylerretzlaff is added to the review. #Closed |
| @@ -271,8 +287,11 @@ IMLow = "Low" | |||
| IMMedium = "Medium" | |||
| TransmitBuffers = "Transmit Buffers" | |||
|
|
|||
| RTL8168.DeviceDesc = "Realtek PCIe GBE Family Controller NetAdapter Sample Driver" | |||
There was a problem hiding this comment.
Realized that the DeviceDesc and DisplayName should not have been changed. Fixed it.
|
@GabrielGravena is added to the review. #Closed |
RtEthSample/RtEthSample.vcxproj
Outdated
| <!-- /Necessary to pick up proper files from local directory when in the IDE--> | ||
| <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" /> | ||
| <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild"> |
There was a problem hiding this comment.
NuGet is used to get the Windows Implementation Library which include the common.h file that is now necessary for this project. It is also the reason for the import on line 45 and for the packages.config file that was added. Not sure if all these changes are necessary or if common.h could have just been included instead.
|
Decided to just add the necessary 3 files from Windows Implementation Library instead of using a nuget package to install the entire package when building. If that was a mistake I can undo that work and just go back to the way it was. |
… builds with VS. Fix the warning by adding 'UNREFERENCED_PARAMETER'
| packet->Layout.Layer2HeaderLength + | ||
| packet->Layout.Layer3HeaderLength; | ||
|
|
||
| UNREFERENCED_PARAMETER(layer4HeaderOffset); |
There was a problem hiding this comment.
Added this here because when building in release mode layer4HeaderOffset does not get referenced and this was causing a warning. Not sure if there is a better way to deal with it.
Updates to the sample RtEth driver.