Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs are built in PR/CI and published as artifact if needed #65

Merged
merged 9 commits into from
Nov 19, 2020
Merged

docs are built in PR/CI and published as artifact if needed #65

merged 9 commits into from
Nov 19, 2020

Conversation

spaceisfun
Copy link
Member

No description provided.

@spaceisfun spaceisfun changed the title docs are built in PR/CI docs are built in PR/CI and published as artifact if needed Nov 18, 2020
@spaceisfun spaceisfun marked this pull request as ready for review November 18, 2020 01:57
@spaceisfun spaceisfun requested a review from hajya November 18, 2020 01:57
@spaceisfun spaceisfun self-assigned this Nov 18, 2020
@spaceisfun spaceisfun added build An issue or improvement in the Azure DevOps build documentation Improvements or additions to documentation labels Nov 18, 2020
hajya
hajya reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@hajya hajya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. :P this is limited to the docfx/api docs afaict.

hajya
hajya reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@hajya hajya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Round 2 "the actually review it edition"

build/azure-pipelines.pr.yml Show resolved Hide resolved
build/azure-pipelines.pr.yml Show resolved Hide resolved
docs/README.md Show resolved Hide resolved
@spaceisfun spaceisfun requested a review from hajya November 18, 2020 20:39
@spaceisfun spaceisfun linked an issue Nov 19, 2020 that may be closed by this pull request
build and publish documentation as part of CI build #63
Open
@spaceisfun spaceisfun removed a link to an issue Nov 19, 2020
build and publish documentation as part of CI build #63
Open
@spaceisfun
Copy link
Member Author

improves #63

hajya
hajya reviewed Nov 19, 2020
View reviewed changes
docs/README.md Show resolved Hide resolved
hajya
hajya reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@hajya hajya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. 1 NIT but really nbd.

@spaceisfun spaceisfun merged commit c0d1858 into microsoft:main Nov 19, 2020
@spaceisfun spaceisfun deleted the checkfordocschanges branch December 8, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajya hajya hajya approved these changes

Assignees

@spaceisfun spaceisfun

Labels
build An issue or improvement in the Azure DevOps build documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaceisfun @hajya