Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put WaveFrontReader.h into DX namespace #167

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Put WaveFrontReader.h into DX namespace #167

merged 6 commits into from
Oct 8, 2024

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Oct 7, 2024 •
edited
Loading

The WaveFrontReader was not using a C++ namespace. This moves it into the DX namespace which I use for a number of utliities.

Also adds Code Coverage support using CMake.

@walbourn walbourn self-assigned this Oct 7, 2024
@walbourn
Copy link
Member Author

walbourn commented Oct 7, 2024 •
edited
Loading

walbourn/directxmeshtest#17

@walbourn walbourn changed the title Add Code Coverage support to CMake Add Code Coverage support using CMake Oct 7, 2024
@walbourn walbourn changed the title Add Code Coverage support using CMake Put WaveFrontReader.h into DX namespace Oct 8, 2024
@walbourn walbourn merged commit 0c4f28c into main Oct 8, 2024
80 checks passed
@walbourn walbourn deleted the codecov branch October 8, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scm-xbox scm-xbox scm-xbox approved these changes

@nadaOuf nadaOuf Awaiting requested review from nadaOuf

@Andrew-Farrier Andrew-Farrier Awaiting requested review from Andrew-Farrier

Assignees

@walbourn walbourn

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walbourn @scm-xbox