Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --enable_each_rank_log when used with PDSH multi-node runner #6863

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Fix --enable_each_rank_log when used with PDSH multi-node runner #6863

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9562b3e
fix
akeshet Dec 13, 2024
ff49114
Update deepspeed/launcher/multinode_runner.py
akeshet Dec 13, 2024
78d4d98
Merge branch 'master' into akeshet/pdsh_rank_log
loadams Dec 13, 2024
ea251ff
Merge branch 'master' into akeshet/pdsh_rank_log
loadams Dec 16, 2024
3dd25b5
Merge branch 'master' into akeshet/pdsh_rank_log
loadams Dec 16, 2024
0bdef9c
Merge branch 'master' into akeshet/pdsh_rank_log
loadams Dec 16, 2024
1f95dde
Merge branch 'master' into akeshet/pdsh_rank_log
loadams Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions deepspeed/launcher/multinode_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ def get_cmd(self, environment, active_resources):
deepspeed_launch.append("--no_local_rank")
if self.args.save_pid:
deepspeed_launch += ["--save_pid", f"{os.getpid()}"]
if self.args.enable_each_rank_log:
deepspeed_launch.append(f"--enable_each_rank_log={args.enable_each_rank_log}")
akeshet marked this conversation as resolved.
Show resolved Hide resolved
if self.args.elastic_training:
deepspeed_launch.append("--enable_elastic_training")
deepspeed_launch.append(f"--max_elastic_nodes={self.args.max_elastic_nodes}")
Expand Down