Fix torch include in op_builder/mlu/fused_adam.py and update no-torch workflow triggers
#6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
changed the title
loadams
commented
Sep 27, 2024
| @@ -5,7 +5,11 @@ | |||
| # DeepSpeed Team | |||
|
|
|||
| from .builder import MLUOpBuilder | |||
| import torch | |||
There was a problem hiding this comment.
FYI @Andy666G - this change broke the no-torch workflow. See more info in the PR comment, but please let us know if you have any concerns with this change,
loadams
changed the title
op_builder/mlu and update no-torch workflow triggers
loadams
changed the title
op_builder/mlu and update no-torch workflow triggersop_builder/mlu/fused_adam.py and update no-torch workflow triggers
tohtana
reviewed
Sep 27, 2024
| @@ -5,7 +5,11 @@ | |||
| # DeepSpeed Team | |||
|
|
|||
| from .builder import MLUOpBuilder | |||
| import torch | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
Can we import torch in multi_tensor_adam if it is the only place where you need torch?
Then you can throw a more specific error when torch is unavailable and multi_tensor_adam is called.
jomayeri
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #6472 caused the no-torch workflow that is an example of how we build the DeepSpeed release package to fail (so we caught this before a release, see more in #6402). These changes also copy the style used to include torch in other accelerator op_builder implementations, such as npu here and hpu here.
This also updates the no-torch workflow to run on all changes to the op_builder directory. The test runs quickly and shouldn't add any additional testing burden there.
Resolves: #6576