Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] support op builder from intel_extension_for_pytorch kernel path #5425

Merged
merged 24 commits into from
Jun 20, 2024

Conversation

YizhouZ
Copy link
Contributor

@YizhouZ YizhouZ commented Apr 17, 2024

#Motivation
From our next release, xpu DeepSpeed related kernels would be put into intel_extension_for_pytorch. This PR is to add new op builders and use kernel path from intel_extension_for_pytorch. More ops like MOE and WOQ will be added.

@YizhouZ YizhouZ marked this pull request as ready for review May 7, 2024 13:29
@YizhouZ YizhouZ requested a review from mrwyattii as a code owner May 7, 2024 13:29
@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 9, 2024

@loadams @mrwyattii Hi, could you help to trigger a CI for this PR? thanks!

@loadams
Copy link
Contributor

loadams commented May 9, 2024

@loadams @mrwyattii Hi, could you help to trigger a CI for this PR? thanks!

Done @YizhouZ - could you run the pre-commit formatter to pass the formatting check? Thanks

@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 13, 2024

@loadams @mrwyattii Hi, could you help to trigger a CI for this PR? thanks!

Done @YizhouZ - could you run the pre-commit formatter to pass the formatting check? Thanks

Fixed! Could you run it again? Thanks.

@tjruwase tjruwase requested review from duli2012 and tjruwase and removed request for mrwyattii May 13, 2024 09:51
@YizhouZ YizhouZ requested a review from awan-10 as a code owner May 14, 2024 07:23
@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 22, 2024

@tjruwase @loadams It seems nv-torch-latest-v100 / unit-tests tests failed somehow in today's merging commit. I did not see any error msg in log, is it something related to CI server?

@loadams
Copy link
Contributor

loadams commented May 22, 2024

@tjruwase @loadams It seems nv-torch-latest-v100 / unit-tests tests failed somehow in today's merging commit. I did not see any error msg in log, is it something related to CI server?

@YizhouZ - this looks to be a transient error on the CI nodes, it should be fixed now.

@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 23, 2024

@tjruwase @loadams It seems nv-torch-latest-v100 / unit-tests tests failed somehow in today's merging commit. I did not see any error msg in log, is it something related to CI server?

@YizhouZ - this looks to be a transient error on the CI nodes, it should be fixed now.

thanks! could you help to trigger CI?

@YizhouZ
Copy link
Contributor Author

YizhouZ commented May 26, 2024

Thanks for triggering CI. Do you have comments on this PR? @loadams @tjruwase

@YizhouZ
Copy link
Contributor Author

YizhouZ commented Jun 5, 2024

Thanks for triggering CI. Do you have comments on this PR? @loadams @tjruwase

Hi @loadams @tjruwase, this PR seems not in the merge queue. Could you give us some suggestions for this PR? Thanks!

@loadams
Copy link
Contributor

loadams commented Jun 5, 2024

Thanks for triggering CI. Do you have comments on this PR? @loadams @tjruwase

Hi @loadams @tjruwase, this PR seems not in the merge queue. Could you give us some suggestions for this PR? Thanks!

Hi @YizhouZ - we just haven't had time to review yet, we will prioritize this.

@YizhouZ
Copy link
Contributor Author

YizhouZ commented Jun 20, 2024

Could you please add this PR into merge queue? Thanks! @tjruwase @loadams

@tjruwase tjruwase added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 20, 2024
@loadams loadams merged commit d254d75 into microsoft:master Jun 20, 2024
13 checks passed
@YizhouZ YizhouZ deleted the yizhou/kernel_path branch June 21, 2024 02:38
@YizhouZ YizhouZ restored the yizhou/kernel_path branch June 27, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants