Add throughput timer configuration #5363
Conversation
The new 'timers' section describes configuration for different timers. Specifically, in the "throughput" section, it is possible to disable the throughput timer (enabled by default). This allows to avoid the performance degradation whenever the throughput measurekent is not needed, for example in production environment. No device synchronize() is invoked when "synchronized" is set to False (default is True). This allows to produce approximate throughput measurements with minimal performance penalty.
deepcharm
requested review from
duli2012,
mrwyattii,
tjruwase and
awan-10
as code owners
|
We've discovered the following issues in the current implementation of the Throughput timer:
The purpose of this PR is to add config options to control the above behavior. |
|
Hi @loadams, all the requested changes are done. If you can please review and trigger the Ci. Thanks |
|
@loadams @mrwyattii Can you help taking this PR further? @deepcharm handled all review comments. |
|
@loadams @mrwyattii @lekurile can this change be merged? |
Sorry for the delay @nelyahu - I will make sure this is merged shortly. |
The new "timers" section describes configuration for different timers. Specifically, in the "throughput" section, it is possible to disable the throughput timer (enabled by default). This allows to avoid the performance degradation whenever the throughput measurement is not needed, for example in production environment. No device synchronize() is invoked when "synchronized" is set to False (default is True). This allows to produce approximate throughput measurements with minimal performance penalty. --------- Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]>
The new "timers" section describes configuration for different timers.
Specifically, in the "throughput" section, it is possible to disable the throughput timer (enabled by default). This allows to avoid the performance degradation whenever the throughput measurement is not needed, for example in production environment.
No device synchronize() is invoked when "synchronized" is set to False (default is True). This allows to produce approximate throughput measurements with minimal performance penalty.