Supporting custom backend for all accelerator. #5298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
reviewed
Mar 19, 2024
| @@ -14,6 +14,7 @@ class OffloadDeviceEnum(str, Enum): | |||
| none = "none" | |||
| cpu = "cpu" | |||
| nvme = "nvme" | |||
| hpu = "hpu" | |||
There was a problem hiding this comment.
hpu is not a memory target for offloading.
Suggested change
| hpu = "hpu" |
tjruwase
reviewed
Mar 19, 2024
| @@ -287,3 +287,7 @@ def build_extension(self): | |||
| @abc.abstractmethod | |||
| def export_envs(self): | |||
| ... | |||
|
|
|||
| @abc.abstractmethod | |||
| def get_accelerator_backend(self, device_index=None): | |||
There was a problem hiding this comment.
compile_backendis a more apt name since it refers to compilation backend.- Compile backend should be global rather than per device.
Suggested change
| def get_accelerator_backend(self, device_index=None): | |
| def get_compile_backend(self): |
tjruwase
reviewed
Mar 19, 2024
| @pytest.mark.parametrize('offload_device', [OffloadDeviceEnum.none, OffloadDeviceEnum.cpu, OffloadDeviceEnum.nvme]) | ||
| @pytest.mark.parametrize( | ||
| 'offload_device', | ||
| [OffloadDeviceEnum.none, OffloadDeviceEnum.cpu, OffloadDeviceEnum.nvme, OffloadDeviceEnum.hpu]) |
There was a problem hiding this comment.
hpu is not an offload device.
tjruwase
requested review from
mrwyattii and
tohtana
and removed request for
mrwyattii
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.