Fix dtype-related RuntimeError when computing scaled global norm #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complete_grad_norm_calculation_for_cpu_offload can return a python int even though scaled_global_norm expects it to always return a python float which makes torch.norm fail with a RuntimeError.
|
@potamides, thanks for this PR. However, it is a duplicate of #5252. |
|
My bad, didn't notice that PR. Closing this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complete_grad_norm_calculation_for_cpu_offloadcan return a python int even thoughscaled_global_normexpects it to always return a python float which makestorch.normfail with a RuntimeError.