Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCLBackend] update API #4378

Merged
merged 9 commits into from
Oct 12, 2023
Merged

[CCLBackend] update API #4378

merged 9 commits into from
Oct 12, 2023

Conversation

Liangliang-Ma
Copy link
Contributor

This PR:

  1. update the interface of comm collectives in CCLbackend. Using collective name to check if the op is supported in cpp.
  2. Provide new_group interface in CCLBackend to support communication in different groups

@tjruwase
Copy link
Contributor

tjruwase commented Oct 3, 2023

@Liangliang-Ma, can you help resolve merge conflict?

@Liangliang-Ma
Copy link
Contributor Author

@Liangliang-Ma, can you help resolve merge conflict?

@tjruwase Thanks for reminding. The conflict is resolved.

@Liangliang-Ma
Copy link
Contributor Author

@tjruwase Can you help to add the PR to merge queue? Thanks

@tjruwase tjruwase added this pull request to the merge queue Oct 12, 2023
Merged via the queue into microsoft:master with commit 4fc181b Oct 12, 2023
15 checks passed
baodii pushed a commit to baodii/DeepSpeed that referenced this pull request Nov 7, 2023
@Liangliang-Ma @tjruwase @baodii
[CCLBackend] update API (microsoft#4378)
b92deec 
* unify ccl.py for cpu and gpu'

* handle all coll in on func

* add coresponding func in cclbackend

* add coresponding pybind func

* change device setting

---------

Co-authored-by: Olatunji Ruwase <[email protected]>
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
@Liangliang-Ma @tjruwase
[CCLBackend] update API (microsoft#4378)
3c99905 
* unify ccl.py for cpu and gpu'

* handle all coll in on func

* add coresponding func in cclbackend

* add coresponding pybind func

* change device setting

---------

Co-authored-by: Olatunji Ruwase <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loadams loadams loadams left review comments

@tjruwase tjruwase tjruwase approved these changes

@awan-10 awan-10 Awaiting requested review from awan-10

@RezaYazdaniAminabadi RezaYazdaniAminabadi Awaiting requested review from RezaYazdaniAminabadi

@jeffra jeffra Awaiting requested review from jeffra

@cmikeh2 cmikeh2 Awaiting requested review from cmikeh2

@arashb arashb Awaiting requested review from arashb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liangliang-Ma @tjruwase @loadams