-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Statsbeat Network data collection #1645
base: master
Are you sure you want to change the base?
Conversation
channels/applicationinsights-channel-js/src/NetworkStatsbeat.ts
Outdated
Show resolved
Hide resolved
channels/applicationinsights-channel-js/src/NetworkStatsbeat.ts
Outdated
Show resolved
Hide resolved
…ights-JS into lxiao/statsbeat
var elapsedMs = currentCounter.time - currentCounter.lastTime; | ||
var averageRequestExecutionTime = ((currentCounter.intervalRequestExecutionTime - currentCounter.lastIntervalRequestExecutionTime) / intervalRequests) || 0; | ||
currentCounter.lastIntervalRequestExecutionTime = currentCounter.intervalRequestExecutionTime; // reset | ||
if (elapsedMs > 0 && intervalRequests > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't averageRequestExecutionTime
be the one that should be checked for negative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hectorhdzg can you please help here thanks! Should it be different from node sdk?
…ights-JS into lxiao/statsbeat
This PR will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action. |
This PR will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action. |
This PR will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action. |
@xiao-lix please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
TODOs and FYI:
throwInternals
as exception for statsbeat?Microsoft.ApplicationInsights.<ikey>.Metric
. This seems too long for statsbeat, but it's required by the SDK if I understand correctly. Reference here.data.baseData.properties
. Thus the queries to get statsbeat data from Web SDK will be different.A sample payload: