add support for basic findOne with ID #147
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that a few developers of our project were surprised that findOne didn't work until I swapped them to findByPk. Figured I'd have a go to see how much effort it was.
Next step would be adding support for cases like:
Which would probably cause a lot more of our codebase to use the dataloader.
findOne({ where: { id: 123 } })
usages.For the tests, I copied findByPk and then made changes, and added an extra test that adding status: 'active' short circuits from the shim (until we add support for it).