Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake WIP #148

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

cmake WIP #148

wants to merge 16 commits into from

Conversation

h0tw1r3
Copy link
Collaborator

@h0tw1r3 h0tw1r3 commented Jul 19, 2015

As I have been working on a cross-platform buildbot, it has become increasingly difficult with the current makefile.

Pull request is for soliciting feedback (good or bad).

@h0tw1r3 h0tw1r3 force-pushed the cmake branch 11 times, most recently from 84c1fdf to c1296b1 Compare July 26, 2015 03:42
@flukejones
Copy link

Excellent! I've yet to get into using cmake - it's very nice to see someone have a go at it.
I do like having a plain old Makefile available though, so lets leave it in for a while longer.

@mickelson
Copy link
Owner

I'm open to moving to cmake if there are advantages to such a move. I know a lot of projects use it so there must be some reason =) I really don't know that much about the topic.

My opinion at this point is that the Makefile seems to work just fine for what I've wanted to do with Attract-Mode. I'm biased due to having spent a lot of time learning how to get the Makefile working for this project, and now cmake looks like a whole other world to figure out ...

I think it would have to be a clean switch, we should go with one or the other and not have to maintain both cmake and a separate makefile

@h0tw1r3
Copy link
Collaborator Author

h0tw1r3 commented Sep 22, 2015

The big benefit that I can see is its much easier to read and debug. Not having to deal as much with the different system/arch dependencies is nice too.

This was my first trial of cmake, so don't judge it to harshly based on this PR :)

I'll keep working on it. There's a lot to clean up.

@h0tw1r3
Copy link
Collaborator Author

h0tw1r3 commented May 3, 2016

Lots of updates. Should be complete with support for all existing options and behavior.

@mickelson
Copy link
Owner

great, I'm hoping to get around to reviewing this and your ffmpeg patch soon.

On May 2, 2016, at 6:12 PM, Jeffrey Clark [email protected] wrote:

Lots of updates. Should be complete with support for all existing options and behavior.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@h0tw1r3 h0tw1r3 force-pushed the cmake branch 2 times, most recently from 30f9df3 to 5ee7efc Compare May 4, 2016 15:41
@h0tw1r3
Copy link
Collaborator Author

h0tw1r3 commented May 4, 2016

cleaned up a bit and squashed.

@h0tw1r3
Copy link
Collaborator Author

h0tw1r3 commented May 14, 2016

Successfully tested on a RPi2, Raspian Jessie, basically following the wiki instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants