[suricate] update sonar project metrics and new project coverage #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicgreffier
reviewed
Jun 3, 2024
There was a problem hiding this comment.
This should be the image of the project-coverage widget itself, not the metrics widget
| usageExample: 'My branch' | ||
| required: false | ||
| - | ||
| name: 'SURI_PULL_REQUEST' |
There was a problem hiding this comment.
Indentation should be fixed (I know it is not fixed in every widget)
| @@ -0,0 +1,4 @@ | |||
| name: Metrics | |||
| description: Display the selected Sonar metrics of a new code in an application | |||
There was a problem hiding this comment.
New widget is only related to coverage, right? If yes, update the description so it specifies it only display Sonar coverage metrics
| @@ -0,0 +1,4 @@ | |||
| name: Metrics | |||
| description: Display the selected Sonar metrics of a new code in an application | |||
| technicalName: sonar | |||
There was a problem hiding this comment.
Technical name should be more precise (and unique), something like sonarProjectCoverage
| @@ -0,0 +1,57 @@ | |||
| .widget.sonar { | |||
There was a problem hiding this comment.
After updating the technical name, think about updating CSS classes righ there
There was a problem hiding this comment.
This was not intended to be committed I guess 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in sonar/project metrics, add the coverage code
create a new project coverage metrics for the new code ( only the new code is concerned by the modifcation)