New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find namespace from topic name #491

Merged

loicgreffier merged 1 commit into master from feat/find-namespace-from-topic

Dec 6, 2024

Collaborator

ThomasCAI-mlv commented Dec 5, 2024 •

edited

Loading

Add the possibility to find the namespace which is the owner of a topic, thanks to a given topic name.

The PR adds the topic query parameter in the LIST namespace API:

if the query parameter is an empty string, the endpoint doesn't filter at all by the topic name.
if the query parameter is not empty, the endpoint finds the namespace which is the owner of the topic. It returns no namespace if no namespace is owner of the topic (or the topic doesn't exist).

Maybe, the implementation could be 2 additional parameters, resource type and resource name, to allow the search on all types of resources (not only topics), I left it to discussion.


          Add topic name query param on LIST namespace API

79a275e

ThomasCAI-mlv added the feature label

ThomasCAI-mlv self-assigned this

sonarqubecloud bot commented Dec 5, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

loicgreffier approved these changes

View reviewed changes

Collaborator

loicgreffier left a comment

@ThomasCAI-mlv OK for me

loicgreffier merged commit c51d9f3 into master

4 checks passed

loicgreffier deleted the feat/find-namespace-from-topic branch

December 6, 2024 14:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature