Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate integration tests to KRaft broker #434

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Migrate integration tests to KRaft broker #434

merged 1 commit into from
Aug 27, 2024

Conversation

loicgreffier
Copy link
Collaborator

No description provided.

@loicgreffier loicgreffier added the enhancement This issue or pull request improves a feature label Aug 26, 2024
Copy link

@loicgreffier
Copy link
Collaborator Author

@ThomasCAI-mlv

This PR migrates current integration tests to KRaft:

@loicgreffier loicgreffier changed the title Migrate integration tests to use KRaft broker Migrate integration tests to KRaft broker Aug 26, 2024
topicAsyncExecutorList.forEach(TopicAsyncExecutor::run);

// Wait for topics to be updated in Kafka broker
Thread.sleep(2000);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sleep patches KRaft-related unstability or general unstability?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it happens after migrating, in TopicIntegrationTest#shouldUpdateTopic, where it takes some time for the broker to update the topic configuration despite Ns4Kafka topic executor ended the synchronization successfully.

It precisely happens when checking the configuration update here:

Without sleeping, retention.ms can be still equal to 60000 (like 1 time over 10...)

I'm still wondering how it can be related to KRaft

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me then

@loicgreffier loicgreffier merged commit b42607c into master Aug 27, 2024
3 checks passed
@loicgreffier loicgreffier deleted the kraft branch August 27, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants