-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate integration tests to KRaft broker #434
Conversation
Quality Gate passedIssues Measures |
This PR migrates current integration tests to KRaft:
|
topicAsyncExecutorList.forEach(TopicAsyncExecutor::run); | ||
|
||
// Wait for topics to be updated in Kafka broker | ||
Thread.sleep(2000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sleep patches KRaft-related unstability or general unstability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it happens after migrating, in TopicIntegrationTest#shouldUpdateTopic
, where it takes some time for the broker to update the topic configuration despite Ns4Kafka topic executor ended the synchronization successfully.
It precisely happens when checking the configuration update here:
ns4kafka/src/test/java/com/michelin/ns4kafka/integration/TopicIntegrationTest.java
Line 342 in 948322f
"retention.ms", "70000")) //This line was changed ns4kafka/src/test/java/com/michelin/ns4kafka/integration/TopicIntegrationTest.java
Line 385 in 948322f
valueToVerify.forEach(entry -> assertEquals(config.get(entry.name()), entry.value()));
Without sleeping, retention.ms
can be still equal to 60000
(like 1 time over 10...)
I'm still wondering how it can be related to KRaft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me then
No description provided.