Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a specific version of a schema #428

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Delete a specific version of a schema #428

merged 3 commits into from
Aug 28, 2024

Conversation

ThomasCAI-mlv
Copy link
Collaborator

No description provided.

@ThomasCAI-mlv ThomasCAI-mlv self-assigned this Aug 12, 2024
@ThomasCAI-mlv ThomasCAI-mlv added the feature This issue adds a new feature label Aug 12, 2024
@ThomasCAI-mlv ThomasCAI-mlv marked this pull request as ready for review August 13, 2024 14:59
loicgreffier
loicgreffier reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@loicgreffier loicgreffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasCAI-mlv

Here is my review. Mostly minor adjustments and a dedicated integration test for all the deletion use-cases.

src/main/java/com/michelin/ns4kafka/controller/SchemaController.java Outdated Show resolved Hide resolved
src/main/java/com/michelin/ns4kafka/controller/SchemaController.java Outdated Show resolved Hide resolved
src/main/java/com/michelin/ns4kafka/controller/SchemaController.java Outdated Show resolved Hide resolved
src/main/java/com/michelin/ns4kafka/service/client/schema/SchemaRegistryClient.java Outdated Show resolved Hide resolved
src/test/java/com/michelin/ns4kafka/controller/SchemaControllerTest.java Outdated Show resolved Hide resolved
src/test/java/com/michelin/ns4kafka/controller/SchemaControllerTest.java Outdated Show resolved Hide resolved
src/test/java/com/michelin/ns4kafka/controller/SchemaControllerTest.java Outdated Show resolved Hide resolved
src/test/java/com/michelin/ns4kafka/controller/SchemaControllerTest.java Outdated Show resolved Hide resolved
src/test/java/com/michelin/ns4kafka/integration/SchemaIntegrationTest.java Show resolved Hide resolved
@ThomasCAI-mlv ThomasCAI-mlv force-pushed the feat/delete-schema-version branch 3 times, most recently from ebfb61a to 9f3d0cc Compare August 28, 2024 08:04
@ThomasCAI-mlv ThomasCAI-mlv force-pushed the feat/delete-schema-version branch from 9f3d0cc to 4aa20bb Compare August 28, 2024 08:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
99.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@loicgreffier loicgreffier changed the title Handle version parameter in DELETE schema API Delete a specific version of a schema Aug 28, 2024
@loicgreffier loicgreffier merged commit 119d1b4 into master Aug 28, 2024
3 checks passed
@loicgreffier loicgreffier deleted the feat/delete-schema-version branch August 28, 2024 13:29
@ThomasCAI-mlv ThomasCAI-mlv mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicgreffier loicgreffier Awaiting requested review from loicgreffier

Assignees

@ThomasCAI-mlv ThomasCAI-mlv

Labels
feature This issue adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasCAI-mlv @loicgreffier