Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle wildcard parameter in ResourceQuota list API #427

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Handle wildcard parameter in ResourceQuota list API #427

merged 3 commits into from
Aug 9, 2024

Conversation

ThomasCAI-mlv
Copy link
Collaborator

No description provided.

@ThomasCAI-mlv ThomasCAI-mlv self-assigned this Aug 6, 2024
@ThomasCAI-mlv ThomasCAI-mlv added the feature This issue adds a new feature label Aug 6, 2024
@ThomasCAI-mlv
Copy link
Collaborator Author

PR to be iso with other GET endpoints
Quota objects are unique per namespace, so the wildcard search of quota has little plus-value

loicgreffier
loicgreffier reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@loicgreffier loicgreffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasCAI-mlv Minor updates before merging

src/main/java/com/michelin/ns4kafka/controller/quota/ResourceQuotaController.java Outdated Show resolved Hide resolved
src/main/java/com/michelin/ns4kafka/service/ResourceQuotaService.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@loicgreffier loicgreffier marked this pull request as ready for review August 9, 2024 08:44
@loicgreffier loicgreffier changed the title Handle wildcard parameter in quota list API Handle wildcard parameter in ResourceQuota list API Aug 9, 2024
@loicgreffier loicgreffier merged commit 3c85dfe into master Aug 9, 2024
3 checks passed
@loicgreffier loicgreffier deleted the get-quotas-filter branch August 9, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicgreffier loicgreffier loicgreffier left review comments

Assignees

@ThomasCAI-mlv ThomasCAI-mlv

Labels
feature This issue adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasCAI-mlv @loicgreffier