Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle wildcard parameter in Streams list API #411

Merged
merged 15 commits into from
Jul 31, 2024
Merged

Handle wildcard parameter in Streams list API #411

merged 15 commits into from
Jul 31, 2024

Conversation

ThomasCAI-mlv
Copy link
Collaborator

No description provided.

@ThomasCAI-mlv ThomasCAI-mlv added the enhancement This issue or pull request improves a feature label Jul 15, 2024
@ThomasCAI-mlv ThomasCAI-mlv added the test Increase test coverage label Jul 15, 2024
@ThomasCAI-mlv ThomasCAI-mlv removed the test Increase test coverage label Jul 15, 2024
@ThomasCAI-mlv ThomasCAI-mlv marked this pull request as ready for review July 15, 2024 15:19
@ThomasCAI-mlv ThomasCAI-mlv self-assigned this Jul 17, 2024
loicgreffier
loicgreffier reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@loicgreffier loicgreffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasCAI-mlv Here is my first review

src/main/java/com/michelin/ns4kafka/controller/StreamController.java Outdated Show resolved Hide resolved
src/main/java/com/michelin/ns4kafka/service/StreamService.java Outdated Show resolved Hide resolved
src/main/java/com/michelin/ns4kafka/util/RegexUtils.java Show resolved Hide resolved
@loicgreffier loicgreffier added feature This issue adds a new feature and removed enhancement This issue or pull request improves a feature labels Jul 23, 2024
@loicgreffier loicgreffier changed the title Add wildcard filter possibility on LIST kafkastream endpoint Handle wildcard parameter in Streams list endpoint Jul 31, 2024
@loicgreffier
Copy link
Collaborator

@ThomasCAI-mlv LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@loicgreffier loicgreffier changed the title Handle wildcard parameter in Streams list endpoint Handle wildcard parameter in Streams list API Jul 31, 2024
@loicgreffier loicgreffier merged commit 58eff83 into master Jul 31, 2024
3 checks passed
@loicgreffier loicgreffier deleted the get-stream-filter branch July 31, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriencalime adriencalime Awaiting requested review from adriencalime

@loicgreffier loicgreffier Awaiting requested review from loicgreffier

Assignees

@ThomasCAI-mlv ThomasCAI-mlv

Labels
feature This issue adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasCAI-mlv @loicgreffier