Add key/value suffix for schema filtering on LITERAL ACL on v3 claim #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
loicgreffier
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided during the v3 endpoint creation to add the same filtering on schema than on topics (see here)
We figured out that a bug appears with LITERAL ACL because we will set the same pattern for "registry-read" role on these ACL (ex:
"^\\Qproject.topic\\E$"). The filtering on schemas list searches literally for schema with theproject.topicname which is incorrect because schemas will be namedproject.topic-keyorproject.topic-valueThis PR fixes the issue by updating the pattern for patterns that do not contain
.*(pattern for prefixed ACL). Then, literal pattern"^\\Qproject.topic\\E$"becomes"^\\Qproject.topic-\\E(key|value)$"