test coverage

michelin · Oct 11, 2024 · 3ed46ed · 3ed46ed
1 parent b155eb0
commit 3ed46ed
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/test/java/com/michelin/ns4kafka/controller/SchemaControllerTest.java b/src/test/java/com/michelin/ns4kafka/controller/SchemaControllerTest.java
@@ -188,7 +188,7 @@ void shouldNotApplySchemaWhenValidationErrors() {
     }
 
     @Test
-    void shouldCreateSchemaInDryRunMode() {
+    void shouldNotCreateSchemaInDryRunMode() {
         Namespace namespace = buildNamespace();
         Schema schema = buildSchema();
 

diff --git a/src/test/java/com/michelin/ns4kafka/service/SchemaServiceTest.java b/src/test/java/com/michelin/ns4kafka/service/SchemaServiceTest.java
@@ -159,7 +159,7 @@ void shouldListSchemaWithWildcardNameParameter() {
                     .grantedTo("myNamespace")
                     .resourcePatternType(AccessControlEntry.ResourcePatternType.LITERAL)
                     .resourceType(AccessControlEntry.ResourceType.TOPIC)
-                    .resource("prefix2.schema2-value")
+                    .resource("prefix2.schema2")
                     .build())
                 .build(),
             AccessControlEntry.builder()
@@ -598,6 +598,7 @@ private SchemaResponse buildSchemaResponse(String subject) {
                     + "\"doc\":\"Last name of the person\"},{\"name\":\"dateOfBirth\",\"type\":[\"null\","
                     + "{\"type\":\"long\",\"logicalType\":\"timestamp-millis\"}],\"default\":null,"
                     + "\"doc\":\"Date of birth of the person\"}]}")
+            .schemaType("AVRO")
             .references(List.of(Schema.SchemaSpec.Reference.builder()
                 .name("HeaderAvro")
                 .subject("header-value")