add unit tests + remove unused import

michelin · Sep 30, 2024 · 06ea05a · 06ea05a
1 parent 2fc68c9
commit 06ea05a
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 3 deletions.
diff --git a/src/main/java/com/michelin/ns4kafka/controller/SchemaController.java b/src/main/java/com/michelin/ns4kafka/controller/SchemaController.java
@@ -14,7 +14,6 @@
 import com.michelin.ns4kafka.util.exception.ResourceValidationException;
 import io.micronaut.http.HttpResponse;
 import io.micronaut.http.HttpStatus;
-import io.micronaut.http.MutableHttpResponse;
 import io.micronaut.http.annotation.Body;
 import io.micronaut.http.annotation.Controller;
 import io.micronaut.http.annotation.Delete;

diff --git a/src/test/java/com/michelin/ns4kafka/controller/SchemaControllerTest.java b/src/test/java/com/michelin/ns4kafka/controller/SchemaControllerTest.java
@@ -641,15 +641,15 @@ void shouldBulkDeleteAllSchemaVersions() {
     @Test
     void shouldBulkDeleteSchemaVersion() {
         Namespace namespace = buildNamespace();
-        Schema schema1 = buildSchema();
+        Schema schema = buildSchema();
         SchemaList schemaList = buildSchemaList();
 
         when(namespaceService.findByName("myNamespace"))
             .thenReturn(Optional.of(namespace));
         when(schemaService.findByWildcardName(namespace, "prefix.subject-value"))
             .thenReturn(Flux.fromIterable(List.of(schemaList)));
         when(schemaService.getSubjectByVersion(namespace, "prefix.subject-value", "1"))
-            .thenReturn(Mono.just(schema1));
+            .thenReturn(Mono.just(schema));
         when(schemaService.deleteVersion(namespace, "prefix.subject-value", "1"))
             .thenReturn(Mono.just(1));
 
@@ -693,6 +693,54 @@ void shouldNotBulkDeleteSchemaVersionWhenEmpty() {
         verify(schemaService, never()).deleteVersion(namespace, "prefix.subject-value", "1");
     }
 
+    @Test
+    void shouldNotBulkDeleteAllSchemaVersionsWhenVersionNotFound() {
+        Namespace namespace = buildNamespace();
+        Schema schema = buildSchema();
+        SchemaList schemaList = buildSchemaList();
+        SchemaList schemaList2 = buildSchemaList2();
+
+        when(namespaceService.findByName("myNamespace"))
+            .thenReturn(Optional.of(namespace));
+        when(schemaService.findByWildcardName(namespace, "prefix.subject*"))
+            .thenReturn(Flux.fromIterable(List.of(schemaList, schemaList2)));
+        when(schemaService.getSubjectLatestVersion(namespace, "prefix.subject-value"))
+            .thenReturn(Mono.just(schema));
+        when(schemaService.getSubjectLatestVersion(namespace, "prefix.subject2-value"))
+            .thenReturn(Mono.empty());
+
+        StepVerifier.create(schemaController.bulkDelete("myNamespace", "prefix.subject*", Optional.empty(), false))
+            .consumeNextWith(response -> assertEquals(HttpStatus.NOT_FOUND, response.getStatus()))
+            .verifyComplete();
+
+        verify(schemaService, never()).deleteAllVersions(namespace, "prefix.subject-value");
+        verify(schemaService, never()).deleteAllVersions(namespace, "prefix.subject2-value");
+    }
+
+    @Test
+    void shouldNotBulkDeleteSchemaVersionWhenVersionNotFound() {
+        Namespace namespace = buildNamespace();
+        Schema schema = buildSchema();
+        SchemaList schemaList = buildSchemaList();
+        SchemaList schemaList2 = buildSchemaList2();
+
+        when(namespaceService.findByName("myNamespace"))
+            .thenReturn(Optional.of(namespace));
+        when(schemaService.findByWildcardName(namespace, "prefix.subject*"))
+            .thenReturn(Flux.fromIterable(List.of(schemaList, schemaList2)));
+        when(schemaService.getSubjectByVersion(namespace, "prefix.subject-value", "1"))
+            .thenReturn(Mono.just(schema));
+        when(schemaService.getSubjectByVersion(namespace, "prefix.subject2-value", "1"))
+            .thenReturn(Mono.empty());
+
+        StepVerifier.create(schemaController.bulkDelete("myNamespace", "prefix.subject*", Optional.of("1"), false))
+            .consumeNextWith(response -> assertEquals(HttpStatus.NOT_FOUND, response.getStatus()))
+            .verifyComplete();
+
+        verify(schemaService, never()).deleteVersion(namespace, "prefix.subject-value", "1");
+        verify(schemaService, never()).deleteVersion(namespace, "prefix.subject2-value", "1");
+    }
+
     @Test
     void shouldNotBulkDeleteAllSchemaVersionsInDryRunMode() {
         Namespace namespace = buildNamespace();
@@ -794,4 +842,12 @@ private SchemaList buildSchemaList() {
                 .build())
             .build();
     }
+
+    private SchemaList buildSchemaList2() {
+        return SchemaList.builder()
+            .metadata(Metadata.builder()
+                .name("prefix.subject2-value")
+                .build())
+            .build();
+    }
 }