feat: replication: propagate commands to replicas

internal/app/server/config/config.go

@@ -14,6 +14,13 @@ const (
 	ReplicaOfKey  = "REPLICAOF"
 )
 
+var (
+	WriteableCommands = map[string]struct{}{
+		"set": {},
+		"del": {},
+	}
+)
+
 var supportedOptions = map[string]struct{}{
 	ListenAddrKey: {},
 	DirKey:        {},

internal/app/server/server.go

@@ -254,6 +254,19 @@ func (s *Server) handleMasterResponse(ctx context.Context, r *resp.Resp, reader
 			s.receiveRDB(ctx, reader)
 		}
 	case resp.Array:
+		cmdName := strings.ToLower(r.Data.([]*resp.Resp)[0].String())
+		args := r.Data.([]*resp.Resp)[1:]
+		cmd, err := s.cFactory.GetCommand(cmdName)
+		if err != nil {
+			logger.Error(ctx, "Unknown command from master: %s", cmdName)
+			return
+		}
+		logger.Info(ctx, "Received command from master, cmd: %s, args: %v", cmdName, args)
+		tmpWriter := resp.NewWriter(&bytes.Buffer{}, resp.RESP3)
+		err = cmd.Execute(s.masterClient, tmpWriter, args)
+		if err != nil {
+			logger.Error(ctx, "Failed to execute command from master: %v", err)
+		}
 	case resp.BulkString:
 	case resp.SimpleError, resp.BulkError:
 		errMsg := r.String()
@@ -478,13 +491,32 @@ func (s *Server) handleMessage(ctx context.Context, cl *client.Client, r *resp.R
 		cl.Writer.Reset()
 		return s.writeError(cl, err)
 	}
+	if _, ok := config.WriteableCommands[cmdName]; ok {
+		s.propagateCommand(ctx, r)
+	}
 	if cmdName == "replconf" && len(args) > 0 && args[0].String() == "listening-port" {
 		s.addReplica(cl)
 	}
 
 	return nil
 }
 
+func (s *Server) propagateCommand(ctx context.Context, r *resp.Resp) {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+
+	// Send the command to each replica
+	for replica := range s.replicas {
+		_, err := replica.Conn().Write(r.RAW())
+		if err != nil {
+			logger.Error(ctx, "Failed to send command to replica %s: %v", replica.ID, err)
+			// Remove disconnected replica
+			delete(s.replicas, replica)
+			replica.Close(ctx)
+		}
+	}
+}
+
 func (s *Server) addReplica(c *client.Client) {
 	s.mu.Lock()
 	defer s.mu.Unlock()

internal/app/server/server_test.go

@@ -93,7 +93,7 @@ func TestGetAndSetCommand(t *testing.T) {
 		{
 			name: "Set and Get with EXAT",
 			setup: func() error {
-				return rdb.SetArgs(ctx, "foo-exat", "bar", redis.SetArgs{ExpireAt: time.Now().Add(100 * time.Millisecond)}).Err()
+				return rdb.SetArgs(ctx, "foo-exat", "bar", redis.SetArgs{ExpireAt: time.Now().Add(500 * time.Millisecond)}).Err()
 			},
 			action: func() (interface{}, error) {
 				return rdb.Get(ctx, "foo-exat").Result()

pkg/command/replconf.go

@@ -25,9 +25,9 @@ func (rc *ReplConf) Execute(c *client.Client, wr *resp.Writer, args []*resp.Resp
 		port := args[1].String()
 		c.ListeningPort = port
 	case "capa":
-		if len(args) < 2 {
-			return wr.WriteError(errors.New("wrong number of arguments for 'replconf capa' command"))
-		}
+		// if len(args) < 2 {
+		// 	return wr.WriteError(errors.New("wrong number of arguments for 'replconf capa' command"))
+		// }
 		// We don't need to handle/save the capa arguments
 	default:
 		return wr.WriteError(fmt.Errorf("unknown replconf subcommand: %s", subCommand))

pkg/resp/resp.go

@@ -370,6 +370,42 @@ func parseLen(line []byte) (int, error) {
 	return n, nil
 }
 
+func (r *Resp) RAW() []byte {
+	switch r.Type {
+	case SimpleString, SimpleError, Integer, Null, Boolean, Double, BigNumber:
+		return []byte(fmt.Sprintf("%c%s\r\n", r.Type, r))
+	case BulkString, BulkError, VerbatimString:
+		if r.Data == nil {
+			return []byte("$-1\r\n")
+		}
+		data := r.Data.([]byte)
+		return []byte(fmt.Sprintf("%c%d\r\n%s\r\n", r.Type, len(data), data))
+	case Array, Pushes, Set:
+		if r.Data == nil {
+			return []byte("*-1\r\n")
+		}
+		elements := r.Data.([]*Resp)
+		b := []byte(fmt.Sprintf("%c%d\r\n", r.Type, len(elements)))
+		for _, elem := range elements {
+			b = append(b, elem.RAW()...)
+		}
+		return b
+	case Map:
+		if r.Data == nil {
+			return []byte("%0\r\n")
+		}
+		m := r.Data.(map[string]*Resp)
+		b := []byte(fmt.Sprintf("%c%d\r\n", r.Type, len(m)))
+		for k, v := range m {
+			b = append(b, []byte(fmt.Sprintf("+%s\r\n", k))...)
+			b = append(b, v.RAW()...)
+		}
+		return b
+	default:
+		return []byte{}
+	}
+}
+
 func (r *Resp) ToResponse() []byte {
 	switch r.Type {
 	case SimpleString, SimpleError, Integer, Null, Boolean, Double, BigNumber: