Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#555
I changed three things:
(1) as before, check_same_thread=False to sqlite3.connect
(2) used a lock for cursor actions to prevent the situation where a query is made before the result for another query is read
(3) used the same lock for instance creation, since two threads could race and create two connections (which is unintended).
An alternative approach is to somehow create a connection per thread, then the locks won't be necessary
This approach sadly introduces an import from
threading
. I hope it is ok, this module should be present in all supported interpreters.