Replace [dev] optional dependencies with requirements-dev.txt

Fixes #519
mhostetter · Nov 4, 2023 · e1a4941 · e1a4941
1 parent 21e2f71
commit e1a4941
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 20 deletions.
diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
@@ -28,8 +28,11 @@ jobs:
       - name: Upgrade pip
         run: python3 -m pip install --upgrade pip
 
-      - name: Install the `galois` package with [dev]
-        run: python3 -m pip install .[dev]
+      - name: Install the dev requirements
+        run: python3 -m pip install -r requirements-dev.txt
+
+      - name: Install the `galois` package
+        run: python3 -m pip install .
 
       - name: Lint with ruff
         run: python3 -m ruff check --output-format=github .
@@ -48,8 +51,11 @@ jobs:
       - name: Upgrade pip
         run: python3 -m pip install --upgrade pip
 
-      - name: Install the `galois` package with [dev]
-        run: python3 -m pip install .[dev]
+      - name: Install the dev requirements
+        run: python3 -m pip install -r requirements-dev.txt
+
+      - name: Install the `galois` package
+        run: python3 -m pip install .
 
       - name: Format with ruff
         run: python3 -m ruff format --check .
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -59,8 +59,11 @@ jobs:
           files: galois-*.whl
           working-directory: dist/
 
-      - name: Install the `galois` package wheel with upgraded [dev]
-        run: python3 -m pip install --upgrade dist/${{ steps.glob.outputs.paths }}[dev]
+      - name: Install the dev dependencies
+        run: python3 -m pip install -r requirements-dev.txt
+
+      - name: Install the `galois` package wheel with upgraded dependencies
+        run: python3 -m pip install --upgrade dist/${{ steps.glob.outputs.paths }}
 
       - name: Test with pytest
         run: python3 -m pytest -n auto --cov=galois --cov-report=xml tests/
@@ -109,8 +112,11 @@ jobs:
       - name: Install minimum package dependencies
         run: python3 -m pip install -r requirements-min.txt
 
-      - name: Install the `galois` package wheel with [dev]
-        run: python3 -m pip install dist/${{ steps.glob.outputs.paths }}[dev]
+      - name: Install the dev dependencies
+        run: python3 -m pip install -r requirements-dev.txt
+
+      - name: Install the `galois` package wheel
+        run: python3 -m pip install dist/${{ steps.glob.outputs.paths }}
 
       - name: Test with pytest
         run: python3 -m pytest -n auto tests/
@@ -156,8 +162,11 @@ jobs:
           files: galois-*.whl
           working-directory: dist/
 
-      - name: Install the `galois` package wheel with upgraded [dev]
-        run: python3 -m pip install --upgrade dist/${{ steps.glob.outputs.paths }}[dev]
+      - name: Install the dev dependencies
+        run: python3 -m pip install -r requirements-dev.txt
+
+      - name: Install the `galois` package wheel with upgraded dependencies
+        run: python3 -m pip install --upgrade dist/${{ steps.glob.outputs.paths }}
 
       - name: Test with pytest
         run: python3 -m pytest -n auto tests/

diff --git a/pyproject.toml b/pyproject.toml
@@ -55,16 +55,7 @@ dependencies = [
 ]
 dynamic = ["version"]
 
-[project.optional-dependencies]
-dev = [
-    "ruff == 0.1.4",
-    "pytest",
-    "pytest-cov[toml]",
-    "pytest-xdist",
-    "pytest-benchmark >= 4.0.0",
-    "requests",
-    "pdfminer.six",
-]
+# [project.optional-dependencies]
 
 [project.urls]
 Homepage = "https://github.com/mhostetter/galois"

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -0,0 +1,7 @@
+ruff == 0.1.4
+pytest
+pytest-cov[toml]
+pytest-xdist
+pytest-benchmark >= 4.0.0
+requests
+pdfminer.six