Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Music Player #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

arminamirinasab
Copy link
Contributor

Hi 👋

I felt that the place of the music player in this program is empty, so I made the music player that was in the navigation dynamic, musics can be change using its JavaScript array. I temporarily disabled the sound volume input so that I can make it dynamic with the sound of the music later.

Good Luck 😉

@mhmdmhd6
Copy link
Owner

mhmdmhd6 commented Jul 31, 2024

Hello!

Thank you for your contribution and for enhancing the music player! I'm currently remaking this project from scratch using React, as it allows for more features and improved functionality compared to pure JavaScript. I’ll definitely incorporate this cool feature in the upcoming updates once the React version is complete.

I’d also be happy to hear any other suggestions you might have and would appreciate any help you can offer during the React remake.

Thanks again for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants