forked from Gizra/drupal-starter
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ogg group and pvb plugin #1
Open
mgurjanov
wants to merge
5
commits into
main
Choose a base branch
from
add_ogg_group_and_pvb_plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitaibu
reviewed
Feb 15, 2023
private function checkMembershipAndSubscribeAccess(NodeInterface $entity, AccountInterface $account) { | ||
$override = FALSE; | ||
|
||
if ($account->isAuthenticated() && ($entity instanceof EntityOwnerInterface) && ($entity->getOwnerId() != $account->id())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`if (!$account->isAuthenticated()) {
// User is not auth ...
return FALSE;
}
amitaibu
reviewed
Feb 15, 2023
$override = FALSE; | ||
|
||
if ($account->isAuthenticated() && ($entity instanceof EntityOwnerInterface) && ($entity->getOwnerId() != $account->id())) { | ||
if (!$this->ogMembershipManager->getMembership($entity, $account->id(), OgMembershipInterface::ALL_STATES)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This includes the Block state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the purpose of Gizra's home assignment for Drupal dev position (BE part). In order to test it you should:
1) Og group content type
2) Adding node of OG group type
3) Node created + view from node author user
4) Group node as seen from anonymous user (showing default og group field)
5) Group node as seen from logged-in user that is not the node author (offering to request subscription but with overridden content showing username and group name)
This is based on Entity View Builder plugin that is overriding OG group entity display based on user role, login and group membership status. Styling is added just to make distinction for this message content as this was actually the task requirement.
6) Result of OG group test file