Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI against PHP 8.4 #30

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Run CI against PHP 8.4 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba73777
Run CI against PHP 8.4
marmichalski Nov 30, 2024
8eb65e1
Run psalm & phpbench only with highest deps on PHP 8.4
marmichalski Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"
os:
- "ubuntu-latest"

Expand All @@ -45,10 +46,12 @@ jobs:
run: composer code-style:check

- name: "Run psalm"
if: ${{ matrix.dependencies == 'highest' || matrix.php != '8.4' }}
run: vendor/bin/psalm

- name: "Run phpunit"
run: vendor/bin/phpunit

- name: "Run phpbench"
if: ${{ matrix.dependencies == 'highest' || matrix.php != '8.4' }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure why we run bench on all matrices anyway. Maybe it would be enough to just always run it on highest?

run: vendor/bin/phpbench run
1 change: 0 additions & 1 deletion .php-cs-fixer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
'@PHP81Migration' => true,
'@Symfony' => true,
'yoda_style' => false,

])
->setFinder($finder)
;
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
},
"require-dev": {
"ext-gmp": "^8.1",
"phpunit/phpunit": "^8.5.26",
"vimeo/psalm": "^4.3.1",
"phpunit/phpunit": "^10.5.38",
"vimeo/psalm": "^5.26.1",
"phpbench/phpbench": "^1.1.1",
"rector/rector": "^0.18.12",
"php-cs-fixer/shim": "^3.41"
"rector/rector": "^1.2",
"php-cs-fixer/shim": "^3.65.0"
},
"suggest": {
"ramsey/uuid": "A PHP 5.4+ library for generating RFC 4122 version 1, 3, 4, and 5 universally unique identifiers (UUID)",
Expand Down
Loading