Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from create-react-app to Vite #435

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Migrate from create-react-app to Vite #435

wants to merge 3 commits into from
+2,455 −7,807

Conversation

sonvir249
Copy link

@sonvir249 sonvir249 commented Apr 10, 2024 •
edited
Loading

Current progress

  1. Upgraded node to 18
  2. Vite integration

@mglaman
Copy link
Owner

mglaman commented Apr 11, 2024

Can this be rebased to remove 8c40738 and 5dce944? They're for the other PR and I may have some changes requested

@mglaman
Copy link
Owner

mglaman commented Apr 11, 2024

Looks like CircleCI needs to have its Node bumped as well in .circleci

@sonvir249
Copy link
Author

Can this be rebased to remove 8c40738 and 5dce944? They're for the other PR and I may have some changes requested

@mglaman #434 is specific to ddev. I think we can merge this. I will rabse current PR with PR-434

@sonvir249
Copy link
Author

Looks like CircleCI needs to have its Node bumped as well in .circleci

@mglaman Yes, I am still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonvir249 @mglaman