Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves C2696 error while using VS 2017 and up #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolves C2696 error while using VS 2017 and up #362

wants to merge 1 commit into from

Conversation

alimoezzi
Copy link

This is for issue #360

@mfontanini
Copy link
Owner

PDU isn't a Packet, this isn't a safe cast. This should be checking the VS version instead. Some older version didn't have enough C++11 support to handle the template types used to do this PDU/Packet dispatching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alimoezzi @mfontanini