Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add control to force potentially existing bookmark to top of list #3808

Open
wants to merge 2 commits into
base: 1.21.x
Choose a base branch
from

Conversation

Goldenlion5648
Copy link

I am the type of player that bookmarks items, but doesn't remove them once done with that item (or the item is used through out the pack). This becomes annoying when I want to put an item near the top of the list (the setting I use), but it is already in the bookmark list.

This PR adds the "shift + a" keybind, which removes an existing bookmark, and adds it back. If the item was not already bookmarked, it is added as if the normal "a" keybind was pressed

@vfyjxf
Copy link
Contributor

vfyjxf commented Oct 12, 2024

Why can't you try dragging the bookmark you want to move to the top, jei supports that.

@Goldenlion5648
Copy link
Author

Why can't you try dragging the bookmark you want to move to the top, jei supports that.

That still requires finding the item in the bookmarks list, which can be annoying if there are multiple pages of bookmarks

@Goldenlion5648
Copy link
Author

Oh wait this currently doesn't work when "shift a" is pressed on an item in the bookmarks (as in hovering an item on the left side of the inventory), it just removes it. New PR incoming

@Goldenlion5648
Copy link
Author

Any update on if this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants