Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP async loading #3219

Draft
wants to merge 23 commits into
base: 1.19.4
Choose a base branch
from
Draft

WIP async loading #3219

wants to merge 23 commits into from

Conversation

mezz
Copy link
Owner

@mezz mezz commented May 15, 2023 •
edited
Loading

This adds two config flags that are disabled by default:

  1. enables async loading of JEI, which means it will not block the world load and it will continue loading in the background for a while before it's available to use.
  2. enables parallel plugin loading. this is more of an experimental config option that will break stuff. Plugins can opt into this more intelligently by implementing the new IAsyncModPlugin instead of IModPlugin.

embeddedt and others added 23 commits April 14, 2023 17:00
@embeddedt
Add config to reload JEI asynchronously
8a443c8
@embeddedt
Add task executor system that runs on the end of a client tick
4f57504
@embeddedt
Add executor to IRuntimeRegistration, and modify ingredient filter
f73ff52 
to cache the tooltips using it
@embeddedt
Add sanity check for tasks enqueued on main thread
2e07a44
@embeddedt
Add ability to configure specific JEI plugins to run on main thread
d4ce812
@embeddedt
Move executor to IJeiHelpers
d29f535
@mezz
Merge remote-tracking branch 'origin/1.19.4' into embeddedt-async-reload
4c85ffe
@mezz
WIP async loading
6b33ae2
@mezz
cleanup
0f1c725
@mezz
fix calls to runtime plugins
1cd6d35
@mezz
fix 'since' tags in IAsyncModPlugin and IRuntimePlugin
411316a
@mezz
fix tests
a33ee6a
@mezz
Simplify use of JeiPlugin
31a6863
@mezz
remove useless interrupt check on client thread
e96d726
@mezz
Only allow one runtime plugin at a time. Use JeiPlugin annotation for…
6f03577 
… all types of plugins
@mezz
simplify JeiStartTask#interruptIfCanceled
d598989
@mezz
move configs to their own subcategory
43d81e7
@mezz
fix crash when plugin uid crashes
2ecf7e6
@mezz
remove parallel loading
442074d
@mezz
remove parallel loading
58f38d3 
# Conflicts:
#	Library/src/main/java/mezz/jei/library/load/PluginCaller.java
#	Library/src/main/java/mezz/jei/library/recipes/RecipeManager.java
#	Library/src/main/java/mezz/jei/library/startup/ClientTaskExecutor.java
@mezz
fix config description
4bfb889
@mezz
fix fabric mod plugin declarations
89aa6da
@mezz
clean up imports
e81d6bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mezz @embeddedt