-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clientside config editable with Configured on Forge 1.19.2 #3148
base: 1.19
Are you sure you want to change the base?
Conversation
…ig implementation to Fabric project
Added IClientConfigs to public API
All tests are passed, spotless check is passed |
Thank you for contributing! |
My solution is not Configured-dependent, it will work with all Forge mods that access configs of other mods. |
I think that sounds beneficial. There are some things to overcome here in the review here though. For PRs, we must target the latest version of JEI and then we can backport to any version you would like. In this case, we need this first PR to target 1.19.3. The dependency structure of JEI is like this:
So for anything you need accessible in forge and fabric, it doesn't need to go in the API at all. |
Hello, sorry to bother, but do i need to change something manually or will it be implemented in next update? |
@Daraphin We will have to wait for the developer to backport the change 4128bf4 to 1.19.2. The Configured change referenced earlier #3148 (comment) has already been merged and released for 1.19.2. For now you can edit configs manually through files or use an alternative. |
(Oh i figured it out so no need for help anymore) Yeah problem is i need this fix for 1.18.2 :X and sorry for late response completly forgot i asked here... |
Fixes #3139.
I exported
IClientConfigs
to public API to make it accessible fromForgeGuiPlugin
andFabricGuiPlugin
.FabricGuiPlugin
has a hack with casting to concrete implementation ofIClientConfigs
, when proper configuration support on fabric will be added, that hack will be not needed.Also added Configured as development dependency for Forge and updated development version of Forge.