User groups #12
User groups #12
Conversation
Improved user flow with signup. Removed redundant routes.
…s they are in, along with their profile. 2. Adds functionality to create, edit, delete groups from the user's dashboard. 3. Makes use of partial renders with create and edit group form.
There was a problem hiding this comment.
@kmeyerhofer Overall looks great. I had a few suggestions below. Please let me know if you wish to discuss further.
A couple of optional items:
- adding group and user group records to seeds would be convenient for other devs
- missing specs -- need these for every model and major feature items (e.g. creating a group and authorization around viewing user show pages)
|
Also forgot to mention -- accurate commit logs 👍 |
… fail check, changes flash message access to be consistent.
…laces .nil? with .empty? check within dashboard#show
|
The requested changes have been addressed and corrected. |
|
Note on commit messages: the message generally should explain what the code change does, not the implementation or how the code makes that change. e.g. "Adds a check for authorized user before displaying XYZ page." instead of "Adds a before_action for the XYZController show page to check for authorized user." |
|
@kmeyerhofer Thank you for all of your work on this! Documenting that the seeds file runs into a uniqueness validation error when running for me locally. Creating fewer user records seems to do the trick. I don't think you need to change it for this PR -- just making note of it. I'm also getting a spec failure on |
|
I've made a note of the commit messages, thanks. The seeds are fixed in branch #14 , the uniquness is definitely addressed there. I just fixed the failing tests for |
Adds the following functionality:
Groups
Users
/profileor/profile/:idpaths./profile/:id)Dashboard
/dashboardwhich shows their groups they belong to and a link to create a new group